Daniel Kimsey created ZOOKEEPER-4391:
----------------------------------------

             Summary: Unable to use newer JVM memory settings as Xmx overrides
                 Key: ZOOKEEPER-4391
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4391
             Project: ZooKeeper
          Issue Type: Improvement
          Components: scripts
            Reporter: Daniel Kimsey


The Zookeeper environment initialization scripts 
[forcibly|https://gitbox.apache.org/repos/asf?p=zookeeper.git;a=blob;f=bin/zkEnv.sh;h=8d93a50c7c0cedee6a23746362e7b6fff96ad61c;hb=refs/heads/master#l144]
 set an {{Xmx}} setting. This is an issue for more flexible configuration JVM 
memory options like ({{MaxRAMPercentage}} and {{InitialRAMPercentage}}) as Xmx 
overrides them.

Ideally, if SERVER_JVMFLAGS/CLIENT_JVMFLAGS are set, we should not attempt to 
modify them as the operator has decided what flags to set. However, this would 
be a behavior change, I don't know if the project is interested/willing to do 
that. Alternatively, we add a flag to disable the default (current) behavior.

{code:sh}
# default heap for zookeeper server
if [ "$ZK_SKIP_XMX" != "yes" ];
  ZK_SERVER_HEAP="${ZK_SERVER_HEAP:-1000}"
  export SERVER_JVMFLAGS="-Xmx${ZK_SERVER_HEAP}m $SERVER_JVMFLAGS"
fi
{code}

Repeat for CLIENT_JVMFLAGS.

Thank you



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to