+1 (non-binding) - I built the source code (-Pfull-build) on Ubuntu 18.04.6 using OpenJDK 11.0.13 and maven 3.6.0. - all the unit tests passed (both Java and C-client), although many (10+) tests failed for the first time, we should improve our flaky test situation. - I also built and executed unit tests for zkpython - checkstyle and spotbugs passed - apache-rat passed - owasp (CVE check) passed - fatjar built - I executed quick rolling-upgrade tests (using https://github.com/symat/zk-rolling-upgrade-test): - rolling upgrade from 3.5.9 to 3.8.0 - rolling upgrade from 3.6.3 to 3.8.0 - rolling upgrade from 3.7.0 to 3.8.0
Best regards, Máté On Mon, Feb 28, 2022 at 10:10 AM Enrico Olivelli <eolive...@gmail.com> wrote: > +1 (binding) > - built and run unit tests on Ubuntu, with JDK11 > - run some tests using Patrick's project > https://github.com/phunt/zkconf (it allows you to easily start a N > servers cluster on a single machine) > > I am sending a patch for the commons-io LICENSE file > (https://issues.apache.org/jira/browse/ZOOKEEPER-4482) > > Enrico > > Il giorno dom 27 feb 2022 alle ore 19:40 Enrico Olivelli > <eolive...@gmail.com> ha scritto: > > > > > > > > Il Dom 27 Feb 2022, 17:51 Patrick Hunt <ph...@apache.org> ha scritto: > >> > >> The license file in the binary (which also comes from the src) doesn't > >> match the jar version: > >> > >> -rw-r--r-- 1 phunt staff 327135 Jan 16 23:54 > commons-io-2.11.0.jar > >> -rw-r--r-- 1 phunt staff 11359 Feb 25 00:47 > >> commons-io-2.7.LICENSE.txt > >> > >> Is this something you want to fix, or not a release blocker, I can't > >> remember how we treat this... > > > > > > We can fix it, let's see how it goes with the other verifications. > > > > I won't consider this a blocker. > > > > Thanks > > For reporting this. > > > > We should have a script that does this verification > > > > Enrico > > > > > > > >> > >> Patrick > >> > >> On Fri, Feb 25, 2022 at 2:32 AM Enrico Olivelli <eolive...@gmail.com> > wrote: > >> > >> > This is the second release candidate for 3.8.0. > >> > > >> > It is a major release and it introduces a lot of new features, most > >> > notably: > >> > - Migration of the logging framework from Apache Log4j1 to LogBack > >> > - Read Key/trust store password from file (and other security related > >> > improvements) > >> > - Restored support for OSGI > >> > - Reduced the performance impact of Prometheus metrics > >> > - Official support for JDK17 (all tests are passing) > >> > - Updates to all the third party dependencies to get rid of every > known > >> > CVE. > >> > > >> > The full release notes is available at: > >> > > >> > > >> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12349587 > >> > > >> > *** Please download, test and vote by February 28th 2022, 23:59 > UTC+0. *** > >> > > >> > Source files: > >> > > >> > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.0-candidate-1/ > >> > > >> > Maven staging repo: > >> > > https://repository.apache.org/content/repositories/orgapachezookeeper-1073/ > >> > > >> > The release candidate tag in git to be voted upon: release-3.8.0-1 > >> > https://github.com/apache/zookeeper/tree/release-3.8.0-1 > >> > > >> > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > >> > https://www.apache.org/dist/zookeeper/KEYS > >> > > >> > The staging version of the website is: > >> > > >> > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.0-candidate-1/website/index.html > >> > > >> > > >> > Should we release this candidate? > >> > Enrico Olivelli > >> > >
