+1 (binding) I did the following tests for the release candidate: - verified checksum and gpg signature of the artifacts - I built the source code (incl. the C-client, using -Pfull-build) on Ubuntu 22.04.3 using OpenJDK 8u402, maven 3.9.6 and GCC version 11.4.0 - all the unit tests passed eventually (both Java and C-client), although I saw a few flakies again - I also built and executed unit tests for zkpython - I also built the java code (without -Pfull-build) using other JDK versions: 11.0.22, 17.0.10, 21.0.1 (but didn't run the tests this time, just used 'clean install -DskipTests') - checkstyle and spotbugs passed - apache-rat passed - owasp (CVE check) passed - fatjar built - I executed quick rolling-upgrade tests without SSL (using https://github.com/symat/zk-rolling-upgrade-test): - rolling upgrade from 3.6.4 to 3.8.4 RC0 - rolling upgrade from 3.7.2 to 3.8.4 RC0 - rolling upgrade from 3.8.3 to 3.8.4 RC0 - rolling upgrade from 3.8.4 RC0 to 3.9.1 - rolling upgrade from 3.8.4 RC0 to 3.9.2 RC0 - checked the uploaded documentation ( https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/website/index.html ) - compared generated release notes ( https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/website/releasenotes.html) with Jira ( https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353693&projectId=12310801 )
Best regards, Máté On Mon, Feb 12, 2024 at 11:35 PM Damien Diederen <ddiede...@apache.org> wrote: > > Greetings, all! > > > This is a release candidate for 3.8.4. > > This is a bugfix release for the 3.8 release line. Includes important > dependency upgrades to address CVEs. > > > The full release notes is available at: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12353693 > > *** Please download, test and vote by February 16th 2024, 23:59 UTC+0. *** > > Source files: > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/ > > Maven staging repo: > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.8.4/ > > The release candidate tag in git to be voted upon: release-3.8.4-0 > https://github.com/apache/zookeeper/releases/tag/release-3.8.4-0 > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > https://www.apache.org/dist/zookeeper/KEYS > > The staging version of the website is: > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/website/index.html > > > Should we release this candidate? > > > Regards, > Damien Diederen >
