Hi, all.
Ralph commited the code that was developed for this RFC (r31908). This
commit will brake PMI1 support. In case of hurry - apply attached patch.
Ralph will apply it once he'll be online. I have no rights for that yet.
2014-05-19 21:18 GMT+07:00 Ralph Castain <[email protected]>:
> WHAT: Refactor the PMI support into something more flexible
>
> WHY: We currently support both PMI-1 and PMI-2. However, a number of
> PMI-2 implementations
> (specifically, in several Slurm releases) have bugs in them
> that cause significant problems.
> In addition, we have new PMI implementations coming along
> that we would also like to support.
> The current support in OMPI is spread across multiple
> locations, each of which must track which
> PMI version is to be used. Centralizing the PMI integration
> allows us to avoid that duplication.
>
> WHERE: https://bitbucket.org/rhc/ompi-pmi
>
> TIMEOUT: June 3rd, after the telecon
>
>
> _______________________________________________
> devel mailing list
> [email protected]
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post:
> http://www.open-mpi.org/community/lists/devel/2014/05/14827.php
>
--
С Уважением, Поляков Артем Юрьевич
Best regards, Artem Y. Polyakov
Index: opal/mca/common/pmi/common_pmi.c
===================================================================
--- opal/mca/common/pmi/common_pmi.c (revision 31908)
+++ opal/mca/common/pmi/common_pmi.c (working copy)
@@ -59,6 +59,7 @@
* even launched by a PMI server before attempting
* to use PMI */
if (NULL == getenv("PMI_FD")) {
+ opal_show_help("help-common-pmi.txt", "pmi2-init-failed", true, rc);
return OPAL_ERROR;
}
@@ -124,13 +125,6 @@
int spawned;
int rc, ret = OPAL_ERROR;
- /* deal with a Slurm bug by first checking if we were
- * even launched by a PMI server before attempting
- * to use PMI */
- if (NULL == getenv("PMI_FD")) {
- return OPAL_ERROR;
- }
-
if (PMI_SUCCESS != (rc = PMI_Initialized(&initialized))) {
OPAL_PMI_ERROR(rc, "PMI_Initialized");
return OPAL_ERROR;