Liming, Is there a place or maybe a spec to summarize the build output file location? Platform may have script to reference some of the output files. Have a clear documentation from now on if there is not could be great to avoid future build breakage due to missing some of output files.
Thanks, Ray > -----Original Message----- > From: [email protected] [mailto:[email protected]] On Behalf Of > Liming Gao > Sent: Tuesday, April 16, 2019 1:11 AM > To: [email protected] > Cc: Feng, Bob C <[email protected]> > Subject: [edk2-devel] [PATCH v2] BaseTools: Remove the unnecessary copy > action for module output files > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1673 > > In v2, keep copy output image into $(BIN_DIR), the platform still uses > the output file in $(BIN_DIR). > > Signed-off-by: Liming Gao <[email protected]> > Cc: Bob Feng <[email protected]> > --- > BaseTools/Conf/build_rule.template | 17 ++--------------- > 1 file changed, 2 insertions(+), 15 deletions(-) > > diff --git a/BaseTools/Conf/build_rule.template > b/BaseTools/Conf/build_rule.template > index 030e74c35a..dbb68c62fb 100755 > --- a/BaseTools/Conf/build_rule.template > +++ b/BaseTools/Conf/build_rule.template > @@ -357,34 +357,21 @@ > > <Command.MSFT, Command.INTEL, Command.RVCT> > "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} ${src} $(GENFW_FLAGS) > - $(CP) ${dst} $(DEBUG_DIR) > $(CP) ${dst} $(BIN_DIR)(+)$(MODULE_NAME_GUID).efi > - -$(CP) $(DEBUG_DIR)(+)*.map $(OUTPUT_DIR) > - -$(CP) $(DEBUG_DIR)(+)*.pdb $(OUTPUT_DIR) > + > <Command.GCC> > $(CP) ${src} $(DEBUG_DIR)(+)$(MODULE_NAME).debug > $(OBJCOPY) --strip-unneeded -R .eh_frame ${src} > - > - # > - #The below 2 lines are only needed for UNIXGCC tool chain, which > generates PE image directly > - # > - -$(OBJCOPY) $(OBJCOPY_ADDDEBUGFLAG) ${src} > - -$(CP) $(DEBUG_DIR)(+)$(MODULE_NAME).debug > $(BIN_DIR)(+)$(MODULE_NAME_GUID).debug > - > "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} ${src} $(GENFW_FLAGS) > - $(CP) ${dst} $(DEBUG_DIR) > $(CP) ${dst} $(BIN_DIR)(+)$(MODULE_NAME_GUID).efi > - -$(CP) $(DEBUG_DIR)(+)*.map $(OUTPUT_DIR) > - > + > <Command.XCODE> > # tool to convert Mach-O to PE/COFF > "$(MTOC)" -subsystem $(MODULE_TYPE) $(MTOC_FLAGS) ${src} > $(DEBUG_DIR)(+)$(MODULE_NAME).pecoff > # create symbol file for GDB debug > -$(DSYMUTIL) ${src} > "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} > $(DEBUG_DIR)(+)$(MODULE_NAME).pecoff $(GENFW_FLAGS) > - $(CP) ${dst} $(DEBUG_DIR) > $(CP) ${dst} $(BIN_DIR)(+)$(MODULE_NAME_GUID).efi > - -$(CP) $(DEBUG_DIR)(+)*.map $(OUTPUT_DIR) > > [Dependency-Expression-File] > <InputFile> > -- > 2.13.0.windows.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39180): https://edk2.groups.io/g/devel/message/39180 Mute This Topic: https://groups.io/mt/31198263/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
