On 05/14/19 09:39, Zhang, Shenglei wrote: > There is a patch to remove the redudant IP4 only iSCSI/PXE/TCP drivers > from MdeModulePkg, which has been reviewed before edk2-stable201811 tag. > And we also have plan to move all network related libraries/modules to > NetworkPkg. In order to make these change more smoothly, 2 configuration > fragment files are provided for platform to enable the network stack > support, without directly reference the INF module path. > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1293 > > Fu Siyuan (4): > OvmfPkg: Update DSC/FDF to use NetworkPkg's include fragment file. > Nt32Pkg: Update DSC/FDF to use NetworkPkg's include fragment file. > ArmVirtPkg: Update DSC/FDF to use NetworkPkg's include fragment file. > EmulatorPkg: Update DSC/FDF to use NetworkPkg's include fragment file. > > ArmVirtPkg/ArmVirt.dsc.inc | 10 +--- > ArmVirtPkg/ArmVirtQemu.dsc | 43 +++++----------- > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 25 +--------- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 43 +++++----------- > EmulatorPkg/EmulatorPkg.dsc | 32 ++++++------ > EmulatorPkg/EmulatorPkg.fdf | 10 +--- > Nt32Pkg/Nt32Pkg.dsc | 75 +++------------------------- > Nt32Pkg/Nt32Pkg.fdf | 27 +--------- > OvmfPkg/OvmfPkgIa32.dsc | 70 ++++++++------------------ > OvmfPkg/OvmfPkgIa32.fdf | 29 +---------- > OvmfPkg/OvmfPkgIa32X64.dsc | 71 ++++++++------------------ > OvmfPkg/OvmfPkgIa32X64.fdf | 29 +---------- > OvmfPkg/OvmfPkgX64.dsc | 69 ++++++++----------------- > OvmfPkg/OvmfPkgX64.fdf | 29 +---------- > 14 files changed, 121 insertions(+), 441 deletions(-) >
Two general comments: (1) We have 4 (not 2) include fragments for the DSC (Defines, Libs, Pcds, Components). This is not really relevant for any of the patches, but it could help with clarifying the blurb, if a v2 is needed. (2) The blurb states that the patches were originally authored by Fu Siyuan. However, the patches themselves don't start with "From: Fu Siyuan ...". This makes me think that the blurb is out of sync with the patches themselves, to some extent. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#40594): https://edk2.groups.io/g/devel/message/40594 Mute This Topic: https://groups.io/mt/31616135/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-