(adding Andrew) On Fri, 17 May 2019 at 18:05, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > > On Fri, 17 May 2019 at 18:03, Leif Lindholm <leif.lindh...@linaro.org> wrote: > > > > On Fri, May 17, 2019 at 05:24:36PM +0200, Ard Biesheuvel wrote: > > > On Tue, 14 May 2019 at 04:08, Wu, Hao A <hao.a...@intel.com> wrote: > > > > > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 > > > > > > > > This commit will update the DSC file to consume the ReportStatusCodeLib > > > > (DXE phase and Runtime instances) in MdeModulePkg, instead of using the > > > > one in IntelFrameworkModulePkg. > > > > > > > > Please note that, the DXE and Runtime ReportStatusCodeLib instances are > > > > almost identical between IntelFrameworkModulePkg and MdeModulePkg. Thus, > > > > there is no functional impact for this commit. > > > > > > > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > > > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > > > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > > > Signed-off-by: Hao A Wu <hao.a...@intel.com> > > > > > > This platform does not have a status code router, so should we not > > > simply switch to BaseReportStatusCodeLibNull.inf here? > > > > Err, yeah, good point. Slight case of tunnel vision. > > > > Actually, I only just figured out that PrePiLib *does* have a status > code router. > > This is slightly dodgy (as is PrePi in general) since it uses a HOB to > expose function pointers into the SEC module, but from the protocol > client pov, it is just a status code router as any other. > > Note that my comment still applies to other platforms that don't use > PrePi (the Styx ones)
... it is not entirely clear to me though how the GUID hobs representing protocol GUIDs get installed into the protocol database. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#40948): https://edk2.groups.io/g/devel/message/40948 Mute This Topic: https://groups.io/mt/31614323/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-