> > 110d4729b58e EmulatorPkg: Add NetworkPkg/NetworkPkg.dec as the > package > > dependency > > Invalid, same as commit 911efe279ec3 above. > > ... No, wait, this is worse: this patch had not received *any* review feedback > on the list: > > 20190520130920.9464-3-liming.gao@intel.com">http://mid.mail-archive.com/20190520130920.9464-3-liming.gao@intel.com > > but it was committed with Ray's R-b. I don't understand. >
Laszlo, The "R-b" thing is my fault. When Liming reminded me to review the patch, I replied "directly" to Liming's mail but forgot to add "devel@edk2.groups.io" to the CC address line. And I just noticed that when I saw Liming forwarded my reply mail out to the public. Maybe we need to set edk2 repo read-only to ordinary developers after soft-freeze starts. Only stewards have the rights to push the changes. But I am not sure whether github supports this feature. Or maybe we could create a branch when soft-freeze starts, and every push on the master will be audited and cherry-picked by stewards. On the date of release, the master branch will be discarded and the branch created before becomes master. Thanks, Ray -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41206): https://edk2.groups.io/g/devel/message/41206 Mute This Topic: https://groups.io/mt/31653140/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
