Hi Steven, The problem isn't that the library dependency is missing. We are missing library artifacts and therefore cannot build the library. This can be fixed with a snippet of your next patch that adds the libraries artifacts, but without the extra tracking information.
Thanks, Christian >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Steven Shi >Sent: Tuesday, May 28, 2019 1:14 AM >To: devel@edk2.groups.io >Cc: Gao, Liming <liming....@intel.com>; Feng, Bob C ><bob.c.f...@intel.com>; Rodriguez, Christian ><christian.rodrig...@intel.com> >Subject: [edk2-devel] [PATCH] BaseTools:Fix the library dependency missing >in Binary Cache > >BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1788 > >The library dependency of a module is wrongly filtered out by binary cache >implementation which cause all dependent libraries will not been built prior to >the module in the build scheduler and the module build fails if cache miss >happen. > >Cc: Liming Gao <liming....@intel.com> >Cc: Bob Feng <bob.c.f...@intel.com> >Cc: Christian Rodriguez <christian.rodrig...@intel.com> >Signed-off-by: Steven Shi <steven....@intel.com> >--- > BaseTools/Source/Python/build/build.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/BaseTools/Source/Python/build/build.py >b/BaseTools/Source/Python/build/build.py >index 80ceb98310..673a9379ba 100644 >--- a/BaseTools/Source/Python/build/build.py >+++ b/BaseTools/Source/Python/build/build.py >@@ -593,7 +593,7 @@ class BuildTask: > # > def AddDependency(self, Dependency): > for Dep in Dependency: >- if not Dep.BuildObject.IsBinaryModule and not >Dep.BuildObject.CanSkipbyHash(): >+ if not Dep.BuildObject.IsBinaryModule: > self.DependencyList.append(BuildTask.New(Dep)) # BuildTask > list > > ## The thread wrapper of LaunchCommand function >-- >2.17.1.windows.2 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41512): https://edk2.groups.io/g/devel/message/41512 Mute This Topic: https://groups.io/mt/31819545/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-