Eric: I have some comments. 1. DebugFeaturePkg DEC/DSC header description should be DebugFeaturePkg instead of DebugAdvancedFeaturePkg 2. DebugFeaturePkg can have one gDebugFeaturePkgTokenSpaceGuid for all PCDs . You don't need to add another gEfiUsb3DebugPortTokenSpaceGuid. 3. Please make PCD TokenNumber are continuous.
Thanks Liming >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Dong, Eric >Sent: Wednesday, May 29, 2019 8:48 AM >To: devel@edk2.groups.io >Subject: [edk2-devel] [Patch 0/3] [edk2-platforms] Add DebugFeaturePkg to >keep debug related modules. > >Add new package in Platform/Intel/ folder to keep debug related >modules. > >Eric Dong (3): > Platform/Intel/DebugFeaturePkg: Add DebugFeaturePkg > Platform/Intel/DebugFeaturePkg: Add USB3DebugPort related modules. > Platform/Intel/DebugFeaturePkg/AcpiDebug: Change AcpiDebug module > location. > > Maintainers.txt | 4 + > .../AdvancedFeaturePkg/AdvancedFeaturePkg.dec | 6 - > .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 3 - > .../AcpiDebug/AcpiDebug.asl | 0 > .../AcpiDebug/AcpiDebug.c | 0 > .../AcpiDebug/AcpiDebugDxe.inf | 8 +- > .../AcpiDebug/AcpiDebugSmm.inf | 8 +- > .../AcpiDebug/Readme.txt | 0 > .../Intel/DebugFeaturePkg/DebugFeaturePkg.dec | 64 ++ > .../Intel/DebugFeaturePkg/DebugFeaturePkg.dsc | 98 ++ > .../Include/Library/Usb3DebugPortLib.h | 76 ++ > .../Library/Usb3DebugPortParameterLib.h | 56 ++ > .../Library/Usb3DebugPortLib/MiscServices.c | 385 ++++++++ > .../Usb3DebugPortDataTransfer.c | 892 ++++++++++++++++++ > .../Usb3DebugPortInitialize.c | 726 ++++++++++++++ > .../Usb3DebugPortLib/Usb3DebugPortLibDxe.c | 454 +++++++++ > .../Usb3DebugPortLib/Usb3DebugPortLibDxe.inf | 55 ++ > .../Usb3DebugPortLibDxeIoMmu.c | 828 ++++++++++++++++ > .../Usb3DebugPortLibDxeIoMmu.inf | 63 ++ > .../Usb3DebugPortLibInternal.h | 887 +++++++++++++++++ > .../Usb3DebugPortLib/Usb3DebugPortLibNull.c | 103 ++ > .../Usb3DebugPortLib/Usb3DebugPortLibNull.inf | 28 + > .../Usb3DebugPortLib/Usb3DebugPortLibPei.c | 236 +++++ > .../Usb3DebugPortLib/Usb3DebugPortLibPei.inf | 48 + > .../Usb3DebugPortLibPeiIoMmu.c | 440 +++++++++ > .../Usb3DebugPortLibPeiIoMmu.inf | 51 + > .../Usb3DebugPortParameterLibPcd.c | 58 ++ > .../Usb3DebugPortParameterLibPcd.inf | 31 + > 28 files changed, 5591 insertions(+), 17 deletions(-) > rename Platform/Intel/{AdvancedFeaturePkg => >DebugFeaturePkg}/AcpiDebug/AcpiDebug.asl (100%) > rename Platform/Intel/{AdvancedFeaturePkg => >DebugFeaturePkg}/AcpiDebug/AcpiDebug.c (100%) > rename Platform/Intel/{AdvancedFeaturePkg => >DebugFeaturePkg}/AcpiDebug/AcpiDebugDxe.inf (79%) > rename Platform/Intel/{AdvancedFeaturePkg => >DebugFeaturePkg}/AcpiDebug/AcpiDebugSmm.inf (80%) > rename Platform/Intel/{AdvancedFeaturePkg => >DebugFeaturePkg}/AcpiDebug/Readme.txt (100%) > create mode 100644 Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec > create mode 100644 Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc > create mode 100644 >Platform/Intel/DebugFeaturePkg/Include/Library/Usb3DebugPortLib.h > create mode 100644 >Platform/Intel/DebugFeaturePkg/Include/Library/Usb3DebugPortParameterL >ib.h > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/MiscServices.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >DataTransfer.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >Initialize.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibDxe.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibDxe.inf > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibDxeIoMmu.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibDxeIoMmu.inf > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibInternal.h > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibNull.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibNull.inf > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibPei.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibPei.inf > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibPeiIoMmu.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibPeiIoMmu.inf > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortParameterLibPcd/U >sb3DebugPortParameterLibPcd.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortParameterLibPcd/U >sb3DebugPortParameterLibPcd.inf > >-- >2.21.0.windows.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41575): https://edk2.groups.io/g/devel/message/41575 Mute This Topic: https://groups.io/mt/31828868/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-