On 06/19/19 14:44, David Woodhouse wrote:
> Signed-off-by: David Woodhouse <dw...@infradead.org>
> ---
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c
> b/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c
> index 05e3ffd2bb..69abd06c40 100644
> --- a/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c
> +++ b/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c
> @@ -568,7 +568,7 @@ ShadowAndStartLegacy16 (
> //
> // Skip Floppy and possible onboard IDE drives
> //
> - EfiToLegacy16BootTable->NumberBbsEntries = 1 + 2 * MAX_IDE_CONTROLLER;
> + EfiToLegacy16BootTable->NumberBbsEntries =
> sizeof(Private->IntThunk->BbsTable) / sizeof(BBS_TABLE);
>
> for (Index = 0; Index < (sizeof (Private->IntThunk->BbsTable) / sizeof
> (BBS_TABLE)); Index++) {
> BbsTable[Index].BootPriority = BBS_IGNORE_ENTRY;
>
>
>
>
If it's possible, please write a non-empty commit message body, for each
patch in this series. Just one sentence on this patch would be nice.
I think your note on patch#2 is valuable too and should be captured in
the commit message body. Please consider formulating it with a bit more
neutral tone :)
With those updates, for these pair of patches:
Acked-by: Laszlo Ersek <ler...@redhat.com>
If you could submit your "csm" branch as a 3-part series (consisting of
these two patches, plus "OvmfPkg: Don't build in QemuVideoDxe when we
have CSM"; with my A-b's / R-b added), that would be great, I could
apply & push it in one go.
If you prefer an actual pullreq (not github pull req), we can "pioneer"
that (for edk2 anyway) too. It will still require a posting to the list,
and then I'll have to compare the commits in the topic branch (subject
to the pull request) against the patches on the list.
Thanks!
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42655): https://edk2.groups.io/g/devel/message/42655
Mute This Topic: https://groups.io/mt/32122467/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
