OK. I think it may break some pre-build script if the pre-build script have "edksetup --nt32"...
-----Original Message----- From: Gao, Liming Sent: Thursday, June 27, 2019 10:48 PM To: Feng, Bob C <bob.c.f...@intel.com>; Bi, Dandan <dandan...@intel.com>; devel@edk2.groups.io Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Bob: --nt32 option is added for Nt32Pkg. Now, Nt32Pkg has been removed. So, I think it is fine to remove --nt32 option. > -----Original Message----- > From: Feng, Bob C > Sent: Thursday, June 27, 2019 7:56 PM > To: Bi, Dandan <dandan...@intel.com>; devel@edk2.groups.io > Cc: Gao, Liming <liming....@intel.com> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files > > The patches look good. > > I think removing --nt32 option is incompatible change. What about keep the > --nt32 ? > > For the Patch 2 setup for different VS tool chains. > Reviewed-by: Bob Feng <bob.c.f...@intel.com> > > Thanks, > Bob > > -----Original Message----- > From: Bi, Dandan > Sent: Sunday, June 23, 2019 9:59 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C <bob.c.f...@intel.com>; Gao, Liming <liming....@intel.com> > Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693 > > Patch 1 remove nt32 related flags in bat files. > Patch 2 setup for different VS tool chains. > > Cc: Bob Feng <bob.c.f...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Dandan Bi (2): > Edk2: Remove nt32 related flag in bat files > Edk2Setup: Support different VS tool chain setup > > BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++---- > BaseTools/set_vsprefix_envs.bat | 47 +++++++++++++++++++++++++--- > BaseTools/toolsetup.bat | 68 > ++++++++++++++++++++++++++++++++++------- > edksetup.bat | 32 ++++++------------- > 4 files changed, 145 insertions(+), 44 deletions(-) > > -- > 1.9.5.msysgit.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42939): https://edk2.groups.io/g/devel/message/42939 Mute This Topic: https://groups.io/mt/32177263/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
