On Wed, Jul 03, 2019 at 09:58:56AM -0700, Cœur wrote: > > Normally, we expect patches to be submitted via git send-email, as > > opposed to through the groups.io web interface (it introduces > > spectacular levels of corruption to the original patch). > > Hello Leif, and thank you for the message and the review. > > I wasn't able to configure ` git send-email ` with my provider > (GMX), and all the doc and support is in German... so basically I > only use emails through web interfaces.
The instructions at https://forum.ubuntuusers.de/topic/git-send-email-smtp-konfiguration/ ought to work, without needing to understand anything except the command line instructions :) > I didn't know there was corruption through the web interface: I > thought the patch format was ASCII-friendly. > > If attachments are fine, then that will also be the easiest for me > in the future, as I won't need to copy-paste the content anymore. It's not ideal, but if the above doesn't work, I'm happy with it for simple things like spelling fixes. For functionality patches, I am much more likely to want to comment inline. > > so could you confirm whether you are happy to contribute these > > patches under BSD+Patent? > > Sure. I'm fine with any license with all my contributions; so > BSD+Patent it is for past and future patches on edk2. Well, not really required (or relevant, you could change your mind :) for future patches - just a sanity check this one. > Do I need to resubmit anything? Or is this declaration enough for > past emails on the mailing list? I think it is sufficient. I have deleted the Contributed-under tags from the ArmPkg, ArmPlatformPkg and EmbeddedPkg patches before pushing them as 080981d72dcb..c6a72cd79465 with my Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> I will reply and cc the individual package maintainers on your other patches to make sure they notice them. > Actually, I can even share the whole 4000+ typos corrections ( > https://github.com/Coeur/edk2/commit/c2eed45a596b42768fe7916fb5491bfc1b9efe0c > ) as CC0 ( https://creativecommons.org/publicdomain/zero/1.0/deed ): > you can cherry pick from it anytime. I don't think there is any > intellectual property possible for spelling corrections anyway. Urgh, don't make me elaborate on the implications of public domain versus copyright... If you're interested, have a look at https://wiki.spdx.org/view/Legal_Team/Decisions/Dealing_with_Public_Domain_within_SPDX_Files Having the patches available in a publicly accessible git tree is however an excellent method to eliminate the problem of patches getting corrupted in transit. Out of interest - how did you find all these typos? I hope it was something at least semi-automated? Best Regards, Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43267): https://edk2.groups.io/g/devel/message/43267 Mute This Topic: https://groups.io/mt/32238806/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-