On 07/16/19 11:41, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 7/16/19 10:38 AM, Philippe Mathieu-Daudé wrote: >> On 7/2/19 12:28 PM, Laszlo Ersek wrote: >>> Rewrite Base64Decode() from scratch, due to reasons listed in the second >>> reference below. >>> >>> As first step, redo the interface contract, and replace the current >>> implementation with a stub that asserts FALSE, then fails. >>> >>> Cc: Liming Gao <[email protected]> >>> Cc: Marvin Häuser <[email protected]> >>> Cc: Michael D Kinney <[email protected]> >>> Cc: Philippe Mathieu-Daudé <[email protected]> >>> Cc: Zhichao Gao <[email protected]> >>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1891 >>> Ref: >>> [email protected]">http://mid.mail-archive.com/[email protected] >>> Signed-off-by: Laszlo Ersek <[email protected]> >>> --- >>> MdePkg/Include/Library/BaseLib.h | 99 +++++-- >>> MdePkg/Library/BaseLib/String.c | 285 ++++++-------------- >>> 2 files changed, 168 insertions(+), 216 deletions(-) > > You forgot to update the copyright in both files.
I didn't: I never intended to. Updating or extending *existing* copyright notices is not a general edk2 requirement. Some companies insist that their associates do that, when they contribute patches. Red Hat doesn't (we don't extend copyright notices like that in QEMU either). Thanks, Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43789): https://edk2.groups.io/g/devel/message/43789 Mute This Topic: https://groups.io/mt/32284615/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
