On 7/18/19 7:40 PM, Leif Lindholm wrote: > On Thu, Jul 18, 2019 at 07:01:40PM +0200, Philippe Mathieu-Daudé wrote: >> Hi Leif, >> >> On 7/18/19 6:27 PM, Leif Lindholm wrote: >>> Laszlo, Hao - I have prepared a set for pushing as below. >>> >>> (Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org >>> <mailto:leif.lindh...@linaro.org>> for all of your patches.) >>> *But*, I need a review from Bob and/or Liming before I push the final one: >>> "BaseTools: add GetMaintainer.py script" - >>> https://edk2.groups.io/g/devel/message/43666 >>> >>> I have verified reviews/acks by all affected reviewers, except for >>> Stefan Berger for Ovmf TCG/TPM2. >>> While I would prefer to have that too, this is a file format shift - not >>> a change in responsibility areas. >> >> As Marc-André and Stefan have the same responsabilities, Marc-André's >> review for their common section should be sufficient, right? > > Pretty much. > >> Now if you want to be kind and patient with Stefan, since this is not a >> logical change blocking anyone, it might be wise to wait over the weekend. >> >> My 2 cents ;) > > Yeah, only thing is it would be nice if we could get the script in > (which is dependent on the Maintainers.txt changes in order to not > give misleading results) with some time to spare (and for it to see > real-world use) before we start the freeze for edk2-stable201908.
Then I insist, since Marc-André reviewed the patch, except for being particularly kind, I don't see any reason to not merge your series ;) Regards, Phil. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43968): https://edk2.groups.io/g/devel/message/43968 Mute This Topic: https://groups.io/mt/32444044/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-