Zhichao: The change looks good. I have one comment to add more descriptions for new introduced two guids. If so, the developer knows how to use them.
Besides, if this patch is for 201908 stable tag, please send RFC for this feature to [email protected] and [email protected] to collect feedbacks. Thanks Liming >-----Original Message----- >From: [email protected] [mailto:[email protected]] On Behalf Of >Gao, Zhichao >Sent: Monday, August 12, 2019 11:08 AM >To: [email protected] >Cc: Wang, Jian J <[email protected]>; Wu, Hao A <[email protected]>; >Ni, Ray <[email protected]>; Zeng, Star <[email protected]>; Laszlo Ersek ><[email protected]>; Ard Biesheuvel <[email protected]>; Leif >Lindholm <[email protected]>; Justen, Jordan L ><[email protected]>; Ma, Maurice <[email protected]>; Dong, >Guo <[email protected]>; You, Benjamin <[email protected]>; Gao, >Liming <[email protected]>; Kinney, Michael D ><[email protected]>; Sean Brogan <[email protected]>; >Michael Turner <[email protected]>; Bret Barkelew ><[email protected]>; Chiu, Chasel <[email protected]> >Subject: [edk2-devel] [PATCH v4 00/15] MdeModulePkg: Transfer reset data > >Indicate two guids gCapsuleArmedResetGuid and >gCapsuleUpdateCompleteResetGuid >for capsule update. And define a struct which start with a null string and >followed by a EFI_GUID. > >V2: >Add prefix Edkii to the new guids. >Move the new struct definition to ResetSystemLib.h. >Fix the wrong reset data to transfer. >Fix the comment of EfiResetSystem in RuntimeLib base on UEFI spec 2.8. > >V3: >Drop 'Move the new struct definition to ResetSystemLib.h.' because the >structure >would be only used in ResetUtilityLib >Using the API ResetSystemWithSubtype in ResetUtilityLib to transfer >a single GUID reset data. >Add ResetUtilityLib to the dsc files that contain CapsuleRuntimeDxe and >CapsuleLib (DxeCapsuleLib instance). > >V4: >Format git config to show the [] section. >Fixed incorrect location of ResetUtilityLib in OvmfPkgIa32X64.dsc. > >Cc: Jian J Wang <[email protected]> >Cc: Hao Wu <[email protected]> >Cc: Ray Ni <[email protected]> >Cc: Star Zeng <[email protected]> >Cc: Laszlo Ersek <[email protected]> >Cc: Ard Biesheuvel <[email protected]> >Cc: Leif Lindholm <[email protected]> >Cc: Jordan Justen <[email protected]> >Cc: Maurice Ma <[email protected]> >Cc: Guo Dong <[email protected]> >Cc: Benjamin You <[email protected]> >Cc: Liming Gao <[email protected]> >Cc: Michael D Kinney <[email protected]> >Cc: Sean Brogan <[email protected]> >Cc: Michael Turner <[email protected]> >Cc: Bret Barkelew <[email protected]> >Cc: Chasel Chiu <[email protected]> >Signed-off-by: Zhichao Gao <[email protected]> > > >Bret Barkelew (3): > MdeModulePkg: Add guids for capsule update > MdeModulePkg/CapsuleRuntimeDxe: Transfer reset data > MdeModulePkg/CapsuleLib: Transfer reset data > >Zhichao Gao (12): > MdeModulePkg: Add ResetUtilityLib to dsc file > ArmVirtPkg/ArmVirtQemu.dsc: Add ResetUtilityLib to dsc file > ArmVritPkg/ArmVirtQemuKernel.dsc: Add ResetUtilityLib to dsc file > ArmVirtPkg/ArmVirtXen.dsc: Add ResetUtilityLib to dsc file > EmulatorPkg/EmulatorPkg.dsc: Add ResetUtilityLib to dsc file > OvmfPkg/OvmfPkgIa32.dsc: Add ResetUtilityLib to dsc file > OvmfPkg/OvmfPkgIa32X64.dsc: Add ResetUtilityLib to dsc file > OvmfPkg/OvmfPkgX64.dsc: Add ResetUtilityLib to dsc file > UefiPayloadPkg/UefiPayloadPkgIa32.dsc: Add ResetUtilityLib to dsc file > UefiPayloadPkg: Add ResetUtilityLib to UefiPayloadPkgIa32X64.dsc > MdePkg/UefiRuntimeLib.h: Change the comment > MdePkg/UefiRuntimeLib: Change the comment > > ArmVirtPkg/ArmVirtQemu.dsc | 1 + > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + > ArmVirtPkg/ArmVirtXen.dsc | 1 + > EmulatorPkg/EmulatorPkg.dsc | 1 + > MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf | 2 ++ > .../Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c | 3 ++- > MdeModulePkg/MdeModulePkg.dec | 4 ++++ > MdeModulePkg/MdeModulePkg.dsc | 1 + > .../Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf | 2 ++ > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.c | 2 +- > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.h | 3 ++- > MdePkg/Include/Library/UefiRuntimeLib.h | 8 ++++---- > MdePkg/Library/UefiRuntimeLib/RuntimeLib.c | 8 ++++---- > OvmfPkg/OvmfPkgIa32.dsc | 2 ++ > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > OvmfPkg/OvmfPkgX64.dsc | 2 ++ > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 2 ++ > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 ++ > 18 files changed, 35 insertions(+), 11 deletions(-) > >-- >2.21.0.windows.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45393): https://edk2.groups.io/g/devel/message/45393 Mute This Topic: https://groups.io/mt/32836892/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
