Yes, as pylama currently not requirement yet we will evaluate this later. Thanks!
Regards, Chasel > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > rebe...@bsdio.com > Sent: Wednesday, August 14, 2019 7:51 PM > To: devel@edk2.groups.io; Chiu, Chasel <chasel.c...@intel.com> > Cc: Feng, Bob C <bob.c.f...@intel.com>; Gao, Liming <liming....@intel.com>; > Leif Lindholm <leif.lindh...@linaro.org> > Subject: Re: [edk2-devel] [PATCH v2] BaseTools/Scripts: Add GetUtcDateTime > script. > > On 2019-08-14 04:21, Chiu, Chasel wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2067 > > > > A script that can return UTC date and time in ascii format which is > > convenient for patching build time information in any binary. > > > I know it's not a required tool to be run before committing, but could > you consider the following issues pylama reported, please? > > BaseTools/Scripts/GetUtcDateTime.py:1:1: E266 too many leading '#' for > block comment [pycodestyle] > BaseTools/Scripts/GetUtcDateTime.py:10:1: E402 module level import not > at top of file [pycodestyle] > BaseTools/Scripts/GetUtcDateTime.py:11:1: E402 module level import not > at top of file [pycodestyle] > BaseTools/Scripts/GetUtcDateTime.py:12:1: E402 module level import not > at top of file [pycodestyle] > BaseTools/Scripts/GetUtcDateTime.py:14:1: E302 expected 2 blank lines, > found 1 [pycodestyle] > BaseTools/Scripts/GetUtcDateTime.py:29:14: E211 whitespace before '(' > [pycodestyle] > BaseTools/Scripts/GetUtcDateTime.py:35:14: E211 whitespace before '(' > [pycodestyle] > BaseTools/Scripts/GetUtcDateTime.py:38:14: E211 whitespace before '(' > [pycodestyle] > BaseTools/Scripts/GetUtcDateTime.py:41:14: E211 whitespace before '(' > [pycodestyle] > BaseTools/Scripts/GetUtcDateTime.py:43:1: E305 expected 2 blank lines > after class or function definition, found 1 [pycodestyle] > > -- > Rebecca Cran > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45620): https://edk2.groups.io/g/devel/message/45620 Mute This Topic: https://groups.io/mt/32862249/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
