Reviewed-by: Liming Gao <liming....@intel.com> > -----Original Message----- > From: Xu, Wei6 > Sent: Tuesday, August 13, 2019 6:53 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A <hao.a...@intel.com>; Gao, Liming <liming....@intel.com> > Subject: [edk2-devel][Patch] MdeModulePkg/CapsuleApp: Improve comparisons in > CapsuleOnDisk.c > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2028 > > Non-Boolean comparisons should use a compare operator > (==, !=, >, < >=, <=). > > Cc: Hao A Wu <hao.a...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Signed-off-by: Wei6 Xu <wei6...@intel.com> > --- > MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c > b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c > index 382efa9aa0..b161d1a981 100644 > --- a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c > +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c > @@ -742,11 +742,11 @@ IsCapsuleOnDiskSupported ( > ); > if (EFI_ERROR (Status)) { > return FALSE; > } > > - if (OsIndicationsSupported & > EFI_OS_INDICATIONS_FILE_CAPSULE_DELIVERY_SUPPORTED) { > + if ((OsIndicationsSupported & > EFI_OS_INDICATIONS_FILE_CAPSULE_DELIVERY_SUPPORTED) != 0) { > return TRUE; > } > > return FALSE; > } > -- > 2.16.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45642): https://edk2.groups.io/g/devel/message/45642 Mute This Topic: https://groups.io/mt/32851273/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
