On 08/15/19 18:08, Michael D Kinney wrote: > Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com>
To summarize: personally, I disgree, but I can accept if the patch goes in with Mike's R-b. Thanks, Laszlo >> -----Original Message----- >> From: devel@edk2.groups.io >> [mailto:devel@edk2.groups.io] On Behalf Of vit9696 via >> Groups.Io >> Sent: Tuesday, August 13, 2019 1:17 AM >> To: devel@edk2.groups.io >> Subject: [edk2-devel] [PATCH v2 1/1] MdePkg: Add >> STATIC_ASSERT macro >> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2048 >> >> Provide a macro for compile time assertions. >> Equivalent to C11 static_assert macro from assert.h. >> >> Signed-off-by: Vitaly Cheptsov <vit9...@protonmail.com> >> --- >> MdePkg/Include/Base.h | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/MdePkg/Include/Base.h >> b/MdePkg/Include/Base.h index >> ce20b5f01dce..f85f7028a262 100644 >> --- a/MdePkg/Include/Base.h >> +++ b/MdePkg/Include/Base.h >> @@ -843,6 +843,17 @@ typedef UINTN *BASE_LIST; >> #define OFFSET_OF(TYPE, Field) ((UINTN) &(((TYPE *)0)- >>> Field)) #endif >> >> +/// >> +/// Portable definition for compile time assertions. >> +/// Equivalent to C11 static_assert macro from >> assert.h. >> +/// Takes condtion and error message as its arguments. >> +/// >> +#ifdef _MSC_EXTENSIONS >> + #define STATIC_ASSERT static_assert >> +#else >> + #define STATIC_ASSERT _Static_assert >> +#endif >> + >> /** >> Macro that returns a pointer to the data structure >> that contains a specified field of >> that data structure. This is a lightweight method >> to hide information by placing a >> -- >> 2.20.1 (Apple Git-117) >> >> >> -=-=-=-=-=-= >> Groups.io Links: You receive all messages sent to this >> group. >> >> View/Reply Online (#45503): >> https://edk2.groups.io/g/devel/message/45503 >> Mute This Topic: https://groups.io/mt/32850582/1643496 >> Group Owner: devel+ow...@edk2.groups.io >> Unsubscribe: https://edk2.groups.io/g/devel/unsub >> [michael.d.kin...@intel.com] >> -=-=-=-=-=-= > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45851): https://edk2.groups.io/g/devel/message/45851 Mute This Topic: https://groups.io/mt/32850582/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
