Currently there is no check for the parameter OutTable. So add the logic that return value EFI_INVALID_PARAMETER when the OutTable is NULL.
Cc: Michael Kubacki <michael.a.kuba...@intel.com> Cc: Chasel Chiu <chasel.c...@intel.com> Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> Cc: Liming Gao <liming....@intel.com> Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com> --- v2:Update the copyright and the if...else statement coding style. .../Test/Library/TestPointCheckLib/DxeCheckAcpi.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpi.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpi.c index 263781a2..83736bf3 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpi.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpi.c @@ -1,6 +1,6 @@ /** @file -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -610,6 +610,8 @@ DumpAcpiRsdt ( if (OutTable != NULL) { *OutTable = NULL; + } else{ + return EFI_INVALID_PARAMETER; } ReturnStatus = EFI_SUCCESS; @@ -663,6 +665,8 @@ DumpAcpiXsdt ( if (OutTable != NULL) { *OutTable = NULL; + } else{ + return EFI_INVALID_PARAMETER; } ReturnStatus = EFI_SUCCESS; -- 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47243): https://edk2.groups.io/g/devel/message/47243 Mute This Topic: https://groups.io/mt/34159564/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-