On 09/17/19 08:19, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186 > > A common terminal console software Putty support various types of > keyboard type, such as normal mode, Linux mode, Xterm R6, Vt400, > VT100+ and SCO. Refer to the link: > https://www.ssh.com/ssh/putty/putty-manuals/0.68/Chapter4.html#config-funkeys > > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Hao A Wu <hao.a...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Liming Gao <liming....@intel.com> > Signed-off-by: Zhichao Gao <zhichao....@intel.com> > --- > MdeModulePkg/Include/Guid/TtyTerm.h | 13 +++++++++++++ > MdeModulePkg/MdeModulePkg.dec | 4 ++++ > 2 files changed, 17 insertions(+) > > diff --git a/MdeModulePkg/Include/Guid/TtyTerm.h > b/MdeModulePkg/Include/Guid/TtyTerm.h > index 8333344b9d..19e0faa8bc 100644 > --- a/MdeModulePkg/Include/Guid/TtyTerm.h > +++ b/MdeModulePkg/Include/Guid/TtyTerm.h > @@ -4,6 +4,7 @@ provide support for modern *nix terminals. > > > Copyright (c) 2015 Linaro Ltd. > +Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -14,6 +15,18 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #define EFI_TTY_TERM_GUID \ > {0x7d916d80, 0x5bb1, 0x458c, {0xa4, 0x8f, 0xe2, 0x5f, 0xdd, 0x51, 0xef, > 0x94 } } > > +#define EDKII_LINUX_MODE_GUID \ > + {0xe4364a7f, 0xf825, 0x430e, {0x9d, 0x3a, 0x9c, 0x9b, 0xe6, 0x81, 0x7c, > 0xa5 } } > + > +#define EDKII_XTERM_R6_GUID \ > + {0xfbfca56b, 0xbb36, 0x4b78, {0xaa, 0xab, 0xbe, 0x1b, 0x97, 0xec, 0x7c, > 0xcb } } > + > +#define EDKII_VT400_GUID \ > + {0x8e46dddd, 0x3d49, 0x4a9d, {0xb8, 0x75, 0x3c, 0x08, 0x6f, 0x6a, 0xa2, > 0xbd } } > + > +#define EDKII_SCO_GUID \ > + {0xfc7dd6e0, 0x813c, 0x434d, {0xb4, 0xda, 0x3b, 0xd6, 0x49, 0xe9, 0xe1, > 0x5a } } > + > extern EFI_GUID gEfiTtyTermGuid; > > #endif > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec > index 17beb45235..67b7bbd83d 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -342,6 +342,10 @@ > > ## Include/Guid/TtyTerm.h > gEfiTtyTermGuid = { 0x7d916d80, 0x5bb1, 0x458c, {0xa4, > 0x8f, 0xe2, 0x5f, 0xdd, 0x51, 0xef, 0x94 }} > + gEdkiiLinuxModeGuid = { 0xe4364a7f, 0xf825, 0x430e, {0x9d, > 0x3a, 0x9c, 0x9b, 0xe6, 0x81, 0x7c, 0xa5 }} > + gEdkiiXtermR6Guid = { 0xfbfca56b, 0xbb36, 0x4b78, {0xaa, > 0xab, 0xbe, 0x1b, 0x97, 0xec, 0x7c, 0xcb }} > + gEdkiiVT400Guid = { 0x8e46dddd, 0x3d49, 0x4a9d, {0xb8, > 0x75, 0x3c, 0x08, 0x6f, 0x6a, 0xa2, 0xbd }} > + gEdkiiSCOGuid = { 0xfc7dd6e0, 0x813c, 0x434d, {0xb4, > 0xda, 0x3b, 0xd6, 0x49, 0xe9, 0xe1, 0x5a }} > > ## Include/Guid/HiiBootMaintenanceFormset.h > gEfiIfrBootMaintenanceGuid = { 0xb2dedc91, 0xd59f, 0x48d2, { 0x89, > 0x8a, 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }} >
Shouldn't we put "Tty" or "Term" or "Terminal" somewhere in the symbolic names of the GUIDs? "Xterm" and "VT400" are OK already, but "LinuxMode" and "SCO" are too general, in my opinion. Just a random comment, I defer to the MdeModulePkg maintainers. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47360): https://edk2.groups.io/g/devel/message/47360 Mute This Topic: https://groups.io/mt/34173529/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
