- The 2nd parameter of EFI_SERVICE_BINDING_CREATE_CHILD is: IN OUT EFI_HANDLE *ChildHandle
- The 2nd parameter of EFI_SERVICE_BINDING_DESTROY_CHILD is: IN EFI_HANDLE ChildHandle Fix the DestroyChild() call in TcpFastbootTransportStop(). This is an actual bugfix; I don't know why the current code doesn't crash. Perhaps the function is never reached in practice? (It could be tied to an error path.) Cc: Ard Biesheuvel <[email protected]> Cc: Leif Lindholm <[email protected]> Signed-off-by: Laszlo Ersek <[email protected]> --- Notes: build-tested only EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c index 29f23a82c75f..34f9ba74e4db 100644 --- a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c +++ b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c @@ -503,7 +503,7 @@ TcpFastbootTransportStop ( Status = mTcpListener->Configure (mTcpListener, NULL); ASSERT_EFI_ERROR (Status); - Status = mTcpServiceBinding->DestroyChild (mTcpServiceBinding, &mTcpHandle); + Status = mTcpServiceBinding->DestroyChild (mTcpServiceBinding, mTcpHandle); // Free any data the user didn't pick up Entry = (FASTBOOT_TCP_PACKET_LIST *) GetFirstNode (&mPacketListHead); -- 2.19.1.3.g30247aa5d201 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47390): https://edk2.groups.io/g/devel/message/47390 Mute This Topic: https://groups.io/mt/34180202/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
