Reviewed-by: Siyuan Fu <[email protected]> > -----Original Message----- > From: Philippe Mathieu-Daudé <[email protected]> > Sent: 2019年9月24日 0:04 > To: [email protected]; [email protected] > Cc: Wu, Jiaxin <[email protected]>; Fu, Siyuan <[email protected]> > Subject: Re: [edk2-devel] [PATCH 20/35] NetworkPkg/Ip4Dxe: fix > NetLibDestroyServiceChild() call > > On 9/17/19 9:49 PM, Laszlo Ersek wrote: > > Both NetLibDestroyServiceChild() and > EFI_SERVICE_BINDING_DESTROY_CHILD > > take an EFI_HANDLE for the "ChildHandle" parameter, not an > (EFI_HANDLE*). > > > > This patch fixes a real bug. > > > > Cc: Jiaxin Wu <[email protected]> > > Cc: Siyuan Fu <[email protected]> > > Signed-off-by: Laszlo Ersek <[email protected]> > > --- > > > > Notes: > > possibly only build-tested > > > > NetworkPkg/Ip4Dxe/Ip4If.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/NetworkPkg/Ip4Dxe/Ip4If.c b/NetworkPkg/Ip4Dxe/Ip4If.c > > index 44b8d9fc8faf..53a333037f94 100644 > > --- a/NetworkPkg/Ip4Dxe/Ip4If.c > > +++ b/NetworkPkg/Ip4Dxe/Ip4If.c > > @@ -592,7 +592,7 @@ Ip4SetAddress ( > > Interface->Controller, > > Interface->Image, > > &gEfiArpServiceBindingProtocolGuid, > > - &Interface->ArpHandle > > + Interface->ArpHandle > > ); > > > > Interface->ArpHandle = NULL; > > @@ -657,7 +657,7 @@ ON_ERROR: > > Interface->Controller, > > Interface->Image, > > &gEfiArpServiceBindingProtocolGuid, > > - &Interface->ArpHandle > > + Interface->ArpHandle > > I'm surprise this one never triggered unexpected behaviors, it > looks easy to reach. > > Reviewed-by: Philippe Mathieu-Daude <[email protected]> > > > ); > > > > return Status; > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48153): https://edk2.groups.io/g/devel/message/48153 Mute This Topic: https://groups.io/mt/34180221/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
