Hi, The 4th version of the patchset introduces minor change in 3/9 and reworks the SMBIOS customization. With the new approach of using the PCDs directly in the tables' template the code is simplified in a great extent - no need to fix length, copy and keep extra variables.
For more details please see the changelog below and commit logs. The patches are available in the github: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/cn913x-upstream-r20191011 I'm looking forward to your comments or remarks. Best regards, Marcin Changelog: v3->v4: * 1/9, 6/9, 7/9 - Add Leif's RB * 3/9 - Change DSC_SPECIFICATION to 0x0001001B - Add Leif's RB * 4/9 - Add Leif's Acked-by * 8/9 - Simplify tables templates creation - use PCDs directly - Remove trailing spaces and "\0" from the default PCDs * 9/9 - Remove trailing spaces and "\0" from the default PCDs v2->v3 * 1/9 - update signatures types in structures (UINTN -> UINT64) - add comment in setting memory size - rework fix for ICU compilation - use fixed type * 2/9 - add Leif's Acked-by * 3/9, 6/9, 7/9 - remove leading __ from include guards in header - require specifying flag for the platform - no default will be built - move dts part to edk2-platforms and update the commit message * 4/9 - squash Xenon-related patches from v2 * 5/9 - Add Leif's RB * 8/9 - Rework patch and allow updating SMBIOS strings from PCDs * 9/9 - New patch, customizing SMBIOS strings for supported boards v1->v2: * 1/10 (new patch) - fix 32-bit compilation * 4/10 - fix OEM Table ID length in DSDT - rename .dsc / .fdf.inc - they are used by all variants * 8,9/10 - remove redundant .dsc / .fdf files - enable building with '-D CN9131' / '-D CN9132' flags - fix OEM Table ID length in SSDT (CN9131) Marcin Wojtas (8): Marvell/Armada7k8k: Fix 32-bit compilation Marvell/Cn9130Db: Add ACPI tables Marvell/Cn9130Db: Introduce board support Marvell/Library: ArmadaSoCDescLib/MppLib: Extend Xenon information Marvell/Library: IcuLib: Fix debug information Marvell/Cn9131Db: Introduce board support Marvell/Cn9132Db: Introduce board support Marvell: Customize per-board SBMIOS strings Patryk Duda (1): Marvell/Drivers: SmbiosPlatformDxe: Load SMBIOS strings from PCD Silicon/Marvell/Marvell.dec | 6 + Platform/Marvell/Cn913xDb/Cn9130DbA.dsc.inc | 107 +++++++ Platform/Marvell/Cn913xDb/Cn9131DbA.dsc.inc | 72 +++++ Platform/Marvell/Cn913xDb/Cn9132DbA.dsc.inc | 72 +++++ Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 4 + Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 4 + Platform/Marvell/Cn913xDb/Cn913xDbA.dsc | 75 +++++ Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc | 5 + Platform/Marvell/Cn913xDb/BoardDescriptionLib/Cn9130DbABoardDescLib.inf | 29 ++ Platform/Marvell/Cn913xDb/BoardDescriptionLib/Cn9132DbABoardDescLib.inf | 29 ++ Platform/Marvell/Cn913xDb/NonDiscoverableInitLib/NonDiscoverableInitLib.inf | 37 +++ Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 4 + Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9130DbA.inf | 56 ++++ Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA.inf | 57 ++++ Platform/Marvell/Cn913xDb/NonDiscoverableInitLib/NonDiscoverableInitLib.h | 25 ++ Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h | 5 +- Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.h | 2 +- Silicon/Marvell/Drivers/Gpio/MvGpioDxe/MvGpioDxe.h | 2 +- Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h | 4 +- Silicon/Marvell/OcteonTx/AcpiTables/T91/AcpiHeader.h | 39 +++ Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn913xDbA/Pcie.h | 20 ++ Silicon/Marvell/OcteonTx/AcpiTables/T91/IcuInterrupts.h | 36 +++ Platform/Marvell/Cn913xDb/BoardDescriptionLib/Cn9130DbABoardDescLib.c | 126 ++++++++ Platform/Marvell/Cn913xDb/BoardDescriptionLib/Cn9132DbABoardDescLib.c | 135 ++++++++ Platform/Marvell/Cn913xDb/NonDiscoverableInitLib/NonDiscoverableInitLib.c | 215 +++++++++++++ Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLibMem.c | 8 + Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c | 34 +- Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 22 +- Silicon/Marvell/Library/IcuLib/IcuLib.c | 4 +- Silicon/Marvell/Library/MppLib/MppLib.c | 4 +- Platform/Marvell/Cn913xDb/Cn913xDbA.fdf.inc | 20 ++ Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/ARM/ArmPlatformHelper.S | 11 - Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl | 98 ++++++ Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn913xDbA/Dsdt.asl | 324 ++++++++++++++++++++ Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn913xDbA/Mcfg.aslc | 41 +++ Silicon/Marvell/OcteonTx/AcpiTables/T91/Fadt.aslc | 80 +++++ Silicon/Marvell/OcteonTx/AcpiTables/T91/Gtdt.aslc | 58 ++++ Silicon/Marvell/OcteonTx/AcpiTables/T91/Madt.aslc | 135 ++++++++ Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc | 210 +++++++++++++ Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc | 49 +++ 40 files changed, 2219 insertions(+), 45 deletions(-) create mode 100644 Platform/Marvell/Cn913xDb/Cn9130DbA.dsc.inc create mode 100644 Platform/Marvell/Cn913xDb/Cn9131DbA.dsc.inc create mode 100644 Platform/Marvell/Cn913xDb/Cn9132DbA.dsc.inc create mode 100644 Platform/Marvell/Cn913xDb/Cn913xDbA.dsc create mode 100644 Platform/Marvell/Cn913xDb/BoardDescriptionLib/Cn9130DbABoardDescLib.inf create mode 100644 Platform/Marvell/Cn913xDb/BoardDescriptionLib/Cn9132DbABoardDescLib.inf create mode 100644 Platform/Marvell/Cn913xDb/NonDiscoverableInitLib/NonDiscoverableInitLib.inf create mode 100644 Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9130DbA.inf create mode 100644 Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA.inf create mode 100644 Platform/Marvell/Cn913xDb/NonDiscoverableInitLib/NonDiscoverableInitLib.h create mode 100644 Silicon/Marvell/OcteonTx/AcpiTables/T91/AcpiHeader.h create mode 100644 Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn913xDbA/Pcie.h create mode 100644 Silicon/Marvell/OcteonTx/AcpiTables/T91/IcuInterrupts.h create mode 100644 Platform/Marvell/Cn913xDb/BoardDescriptionLib/Cn9130DbABoardDescLib.c create mode 100644 Platform/Marvell/Cn913xDb/BoardDescriptionLib/Cn9132DbABoardDescLib.c create mode 100644 Platform/Marvell/Cn913xDb/NonDiscoverableInitLib/NonDiscoverableInitLib.c create mode 100644 Platform/Marvell/Cn913xDb/Cn913xDbA.fdf.inc create mode 100644 Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl create mode 100644 Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn913xDbA/Dsdt.asl create mode 100644 Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn913xDbA/Mcfg.aslc create mode 100644 Silicon/Marvell/OcteonTx/AcpiTables/T91/Fadt.aslc create mode 100644 Silicon/Marvell/OcteonTx/AcpiTables/T91/Gtdt.aslc create mode 100644 Silicon/Marvell/OcteonTx/AcpiTables/T91/Madt.aslc create mode 100644 Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc create mode 100644 Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc -- 2.7.4 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48829): https://edk2.groups.io/g/devel/message/48829 Mute This Topic: https://groups.io/mt/34494702/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-