On 10/22/19 6:08 PM, Michael D Kinney wrote:
Response below.
Mike
-----Original Message-----
From: Philippe Mathieu-Daudé <phi...@redhat.com>
Sent: Tuesday, October 22, 2019 5:41 AM
To: devel@edk2.groups.io; Kinney, Michael D
<michael.d.kin...@intel.com>
Cc: Sean Brogan <sean.bro...@microsoft.com>; Yao,
Jiewen <jiewen....@intel.com>; Wang, Jian J
<jian.j.w...@intel.com>; Zhang, Chao B
<chao.b.zh...@intel.com>
Subject: Re: [edk2-devel] [Patch] SecurityPkg: Fix
spelling errors
Hi Michael,
Few review comment below.
On 10/18/19 9:01 PM, Michael D Kinney wrote:
From: Sean Brogan <sean.bro...@microsoft.com>
https://bugzilla.tianocore.org/show_bug.cgi?id=2265
Cc: Jiewen Yao <jiewen....@intel.com>
Cc: Jian J Wang <jian.j.w...@intel.com>
Cc: Chao Zhang <chao.b.zh...@intel.com>
Signed-off-by: Michael D Kinney
<michael.d.kin...@intel.com>
---
[...]
--- a/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
+++ b/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
@@ -1,7 +1,7 @@
/** @file
TCG MOR (Memory Overwrite Request) Control
Driver.
- This driver initilize
MemoryOverwriteRequestControl variable. It
+ This driver initialize
MemoryOverwriteRequestControl variable. It
will clear MOR_CLEAR_MEMORY_BIT bit if it is set.
It will also do TPer Reset for
those encrypted drives through
EFI_STORAGE_SECURITY_COMMAND_PROTOCOL at EndOfDxe.
@@ -298,7 +298,7 @@ TPerResetAtEndOfDxe (
@param[in] ImageHandle Image handle of this
driver.
@param[in] SystemTable A Pointer to the EFI
System Table.
- @retval EFI_SUCEESS
+ @retval EFI_SUCCESS
@return Others Some error occurs.
**/
EFI_STATUS
@@ -341,7 +341,7 @@ MorDriverEntryPoint (
//
// Create a Ready To Boot Event and Clear the
MorControl bit in the call back function.
//
- DEBUG ((EFI_D_INFO, "TcgMor: Create ReadyToBoot
Event for MorControl Bit cleanning!\n"));
+ DEBUG ((DEBUG_INFO, "TcgMor: Create ReadyToBoot
Event for MorControl Bit cleaning!\n"));
Hmm this is not a spelling change...
The original fix from Sean is for cleanning -> cleaning.
PatchCheck.py gets an error on this patch because EFI_D_ERROR
should not be used, so I added the change to use DEBUG_INFO
to pass PatchCheck.py.
I see. Since you need to respin to fix the "Volume" typo, do you mind
adding a preliminary patch doing the EFI_D_INFO -> DEBUG_INFO conversion
to satisfy PatchCheck.py, then the spelling changes?
[...]
@@ -146,7 +146,7 @@ EFI_PEI_NOTIFY_DESCRIPTOR
mNotifyList[] = {
};
/**
- Record all measured Firmware Volum Information
into a Guid Hob
+ Record all measured Firmware Voluem Information
into a Guid Hob
Typo "Volume"
Guid Hob payload layout is
UINT32 ***************************
FIRMWARE_BLOB number
@@ -501,7 +501,7 @@ MeasureMainBios (
}
/**
- Measure and record the Firmware Volum Information
once FvInfoPPI install.
+ Measure and record the Firmware Voluem Information
once FvInfoPPI install.
Ditto "Volume"
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49353): https://edk2.groups.io/g/devel/message/49353
Mute This Topic: https://groups.io/mt/35082674/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
