Reviewed-by: Sai Chaganty <[email protected]> -----Original Message----- From: Desimone, Nathaniel L Sent: Thursday, November 21, 2019 12:59 AM To: [email protected] Cc: Chiu, Chasel <[email protected]>; Kubacki, Michael A <[email protected]>; Chaganty, Rangasai V <[email protected]> Subject: [edk2-platforms] [PATCH V2 01/14] KabylakeSiliconPkg: Change MODULE_TYPE of SiliconInitLib to PEIM
This library contains PEI phase only code. For example, ClearIchSmiAndWake() calls PeiServicesGetBootMode(). Accordingly, this library should have never been marked as a BASE library. Cc: Chasel Chiu <[email protected]> Cc: Michael Kubacki <[email protected]> Cc: Sai Chaganty <[email protected]> Signed-off-by: Nate DeSimone <[email protected]> --- .../PeiSiliconInitLib.inf} | 5 +++-- .../{SiliconInitLib => PeiSiliconInitLib}/SiliconInit.c | 0 .../SiliconInitPreMem.c | 0 3 files changed, 3 insertions(+), 2 deletions(-) rename Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib/SiliconInitLib.inf => PeiSiliconInitLib/PeiSiliconInitLib.inf} (86%) rename Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib => PeiSiliconInitLib}/SiliconInit.c (100%) rename Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib => PeiSiliconInitLib}/SiliconInitPreMem.c (100%) diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitLib.inf b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSiliconInitLib.inf similarity index 86% rename from Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitLib.inf rename to Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSiliconInitLib.inf index 132080e876..bd77b081e5 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitLib.inf +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSili +++ conInitLib.inf @@ -11,8 +11,9 @@ BASE_NAME = SiliconInitLib FILE_GUID = 72CD3A7B-FEA5-4F5E-9165-4DD12187BB13 VERSION_STRING = 1.0- MODULE_TYPE = BASE- LIBRARY_CLASS = SiliconInitLib+ MODULE_TYPE = PEIM+ LIBRARY_CLASS = SiliconInitLib|SEC PEIM+ # # The following information is for reference only and not required by the build tools. #diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInit.c b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c similarity index 100% rename from Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInit.c rename to Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitPreMem.c b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreMem.c similarity index 100% rename from Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitPreMem.c rename to Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreMem.c -- 2.24.0.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51159): https://edk2.groups.io/g/devel/message/51159 Mute This Topic: https://groups.io/mt/61073527/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
