On 11/25/19 12:10, Sami Mujawar wrote: > Apologies, I missed #28 'Pick up the tags that you got on the list', from > Laszlo's guide. > > This patch has also received a Reviewed-by from: > Reviewed-by: [email protected] > Reviewed-by: Laszlo Ersek <[email protected]>
Right, I noticed, but I figured I wouldn't obsess about it. :) Thank you though! Laszlo > -----Original Message----- > From: Sami Mujawar <[email protected]> > Sent: 25 November 2019 09:06 AM > To: [email protected] > Cc: Sami Mujawar <[email protected]>; Achin Gupta <[email protected]>; > [email protected]; Supreeth Venkatesh <[email protected]>; > [email protected]; Matteo Carlini <[email protected]>; Laura Moretta > <[email protected]>; nd <[email protected]> > Subject: [PATCH v2 1/1] StandaloneMmPkg: Fix build failure - Bug 2253 > > The StandaloneMmPkg currently has code for supporting Arm architecture only. > Support for X64 and IA32 is currently under development on a separate branch. > > However, StandaloneMmPkg/StandaloneMmPkg.dsc is indicating that support for > X64 and IA32 is available which is causing build failures. > This has been reported in > https://bugzilla.tianocore.org/show_bug.cgi?id=2253 > > This issue has been discussed earlier on the list: > (1) https://edk2.groups.io/g/devel/message/47276 > > (2) https://edk2.groups.io/g/devel/message/47283 > > In light of the above, this patch removes IA32 and X64 from > SUPPORTED_ARCHITECTURES, until support for the respective architectures is > merged into StandaloneMmPkg. > > Cc: Achin Gupta <[email protected]> > Cc: Jiewen Yao <[email protected]> > Cc: Supreeth Venkatesh <[email protected]> > Cc: Laszlo Ersek <[email protected]> > Signed-off-by: Sami Mujawar <[email protected]> > > --- > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/697_stmm_disable_unsupported_arch_v1 > > Notes: > v2: > - Fixed patch check failure in commit message, [SAMI] > changed 'CC' to 'Cc'. No code change. > v1: > - Fix for Bug 2253 [SAMI] > (https://bugzilla.tianocore.org/show_bug.cgi?id=2253) > > StandaloneMmPkg/StandaloneMmPkg.dsc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc > b/StandaloneMmPkg/StandaloneMmPkg.dsc > index > 8a68d397469bdb83586bfeaebedcd52fd528b20f..f9546e182e25fbcd253de0986a1bb554dae1e975 > 100644 > --- a/StandaloneMmPkg/StandaloneMmPkg.dsc > +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc > @@ -2,7 +2,7 @@ > # Standalone MM Platform. > # > # Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> -# > Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.<BR> > +# Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.<BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -19,7 +19,7 @@ [Defines] > PLATFORM_VERSION = 1.0 > DSC_SPECIFICATION = 0x00010011 > OUTPUT_DIRECTORY = Build/StandaloneMm > - SUPPORTED_ARCHITECTURES = IA32|X64|AARCH64 > + SUPPORTED_ARCHITECTURES = AARCH64 > BUILD_TARGETS = DEBUG|RELEASE > SKUID_IDENTIFIER = DEFAULT > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51240): https://edk2.groups.io/g/devel/message/51240 Mute This Topic: https://groups.io/mt/61916708/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
