On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur <co...@gmx.fr>
> 
> Fix few typos in comments and documentation.
> 
> Cc: Jordan Justen <jordan.l.jus...@intel.com>
> Cc: Laszlo Ersek <ler...@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
> Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <phi...@redhat.com>
> ---
>  OvmfPkg/Csm/Include/Protocol/IsaAcpi.h | 2 +-
>  OvmfPkg/AcpiPlatformDxe/BootScript.c   | 2 +-
>  OvmfPkg/AcpiTables/Facp.aslc           | 8 ++++----
>  OvmfPkg/AcpiTables/Facs.aslc           | 4 ++--
>  OvmfPkg/AcpiTables/Madt.aslc           | 2 +-
>  5 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h 
> b/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h
> index 12aeb1227c54..0ff57aa118ca 100644
> --- a/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h
> +++ b/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h
> @@ -131,7 +131,7 @@ EFI_STATUS
>  
>    This services sets the power state of the ISA controller specified by 
> Device to
>    the power state specified by OnOff.  TRUE denotes on, FALSE denotes off.
> -  If the power state is sucessfully set on the ISA Controller, then
> +  If the power state is successfully set on the ISA Controller, then
>    EFI_SUCCESS is returned.
>  
>    @param[in] This     The pointer to the EFI_ISA_ACPI_PROTOCOL instance.
> diff --git a/OvmfPkg/AcpiPlatformDxe/BootScript.c 
> b/OvmfPkg/AcpiPlatformDxe/BootScript.c
> index 7137994471bd..7b1b9586da41 100644
> --- a/OvmfPkg/AcpiPlatformDxe/BootScript.c
> +++ b/OvmfPkg/AcpiPlatformDxe/BootScript.c
> @@ -240,7 +240,7 @@ FatalError:
>                          Script opcodes. If the function returns successfully,
>                          the caller must set the S3Context pointer -- 
> originally
>                          returned by AllocateS3Context() -- immediately to 
> NULL,
> -                        because the ownership of S3Context has been 
> transfered.
> +                        because the ownership of S3Context has been 
> transferred.
>  
>    @retval EFI_SUCCESS The translation of S3Context to ACPI S3 Boot Script
>                        opcodes has been successfully executed or queued. (This
> diff --git a/OvmfPkg/AcpiTables/Facp.aslc b/OvmfPkg/AcpiTables/Facp.aslc
> index 8829c1808a70..657a8c645821 100644
> --- a/OvmfPkg/AcpiTables/Facp.aslc
> +++ b/OvmfPkg/AcpiTables/Facp.aslc
> @@ -21,7 +21,7 @@ EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE FACP = {
>      EFI_ACPI_CREATOR_ID,        // ASL compiler vendor ID
>      EFI_ACPI_CREATOR_REVISION   // ASL compiler revision number
>    },
> -  0,                // Physical addesss of FACS
> +  0,                // Physical address of FACS
>    0,                // Physical address of DSDT
>    RESERVED,         // System Interrupt Model in ACPI 1.0, eliminated in 2.0
>    EFI_ACPI_2_0_PM_PROFILE_UNSPECIFIED, // Preferred PM profile
> @@ -62,8 +62,8 @@ EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE FACP = {
>    GAS2_IO(RESET_REG, 1), // Extended address of the Reset Register
>    RESET_VALUE,           // Value for the Reset Register to reset the system
>    { RESERVED },     // reserved[3]
> -  0,                // 64-bit physical addesss of FACS, set at installation
> -  0,                // 64-bit physical addesss of DSDT, set at installation
> +  0,                // 64-bit physical address of FACS, set at installation
> +  0,                // 64-bit physical address of DSDT, set at installation
>  
>    GAS2_IO(PM1a_EVT_BLK, PM1_EVT_LEN), // Ext. addr. of PM 1a Event Reg Blk
>    { 0 },                              // PM 1b Event Reg Blk unsupported
> @@ -83,7 +83,7 @@ ReferenceAcpiTable (
>  {
>    //
>    // Reference the table being generated to prevent the optimizer from 
> removing the
> -  // data structure from the exeutable
> +  // data structure from the executable
>    //
>    return (VOID*)&FACP;
>  }
> diff --git a/OvmfPkg/AcpiTables/Facs.aslc b/OvmfPkg/AcpiTables/Facs.aslc
> index 56f86c1ca4fd..8257c4bc6416 100644
> --- a/OvmfPkg/AcpiTables/Facs.aslc
> +++ b/OvmfPkg/AcpiTables/Facs.aslc
> @@ -70,8 +70,8 @@ ReferenceAcpiTable (
>    )
>  {
>    //
> -  // Reference the table being generated to prevent the optimizer from 
> removing the
> -  // data structure from the exeutable
> +  // Reference the table being generated to prevent the optimizer from 
> removing the 

The line above introduces a stray space character before the CRLF.
Please remove it. (I.e., the line starting with "Reference..." should
not be changed.) With that:

Reviewed-by: Laszlo Ersek <ler...@redhat.com>

Thanks
Laszlo

> +  // data structure from the executable
>    //
>    return (VOID*)&FACS;
>  }
> diff --git a/OvmfPkg/AcpiTables/Madt.aslc b/OvmfPkg/AcpiTables/Madt.aslc
> index 44ffd3726500..02fc3649a0d0 100644
> --- a/OvmfPkg/AcpiTables/Madt.aslc
> +++ b/OvmfPkg/AcpiTables/Madt.aslc
> @@ -147,7 +147,7 @@ ReferenceAcpiTable (
>  {
>    //
>    // Reference the table being generated to prevent the optimizer from 
> removing the
> -  // data structure from the exeutable
> +  // data structure from the executable
>    //
>    return (VOID*)&Madt;
>  }
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51662): https://edk2.groups.io/g/devel/message/51662
Mute This Topic: https://groups.io/mt/65924802/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to