Michael, I had misunderstanding earlier. Thanks for the explanation. Thanks, Ray
> -----Original Message----- > From: Kubacki, Michael A <michael.a.kuba...@intel.com> > Sent: Wednesday, December 18, 2019 7:58 AM > To: Ni, Ray <ray...@intel.com> > Cc: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; > devel@edk2.groups.io; Chiu, Chasel > <chasel.c...@intel.com>; Agyeman, Prince <prince.agye...@intel.com> > Subject: RE: [edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatformPkg: Add > BDS Hook Point Guids > > Hi Ray, > > There could be usage of SimpleTextIn->ReadKeyStroke () in > PlatformBootManagerWaitCallback () and > PlatformBootManagerUnableToBoot (). The PlatformBootManagerLib instance > introduced in MinPlatformPkg simply > forwards those calls to a library instance of BoardBootManagerLib implemented > in the board package so they will still be > invoked at TPL_APPLICATION. > > A specific use case that requires TPL_APPLICATION (the restriction is > relatively minimal) has not been identified in the > analysis of use cases that led to the event hook points introduced in > PlatformBootManagerLib. > > Thanks, > Michael > > > -----Original Message----- > > From: Ni, Ray <ray...@intel.com> > > Sent: Monday, December 16, 2019 12:50 AM > > To: Kubacki, Michael A <michael.a.kuba...@intel.com> > > Cc: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; > > devel@edk2.groups.io; Chiu, Chasel <chasel.c...@intel.com>; Agyeman, > > Prince <prince.agye...@intel.com> > > Subject: RE: [edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatformPkg: > > Add BDS Hook Point Guids > > > > Using event for callbacks has a limitation: The event callback has to run > > at TPL > > >= TPL_CALLBACK. > > > > Some of the services like gBS->LoadImage()/StartImage(), SimpleTextIn- > > >ReadKeyStroke(), > > FormBrowser->SendForm() can ONLY be called at TPL_APPLICATION. > > So those services cannot be called from the event callback. > > > > Is that ok to the min-platform? > > > > Thanks, > > Ray > > > > > > > -----Original Message----- > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chiu, > > > Chasel > > > Sent: Monday, December 16, 2019 9:32 AM > > > To: Agyeman, Prince <prince.agye...@intel.com>; devel@edk2.groups.io > > > Cc: Kubacki, Michael A <michael.a.kuba...@intel.com>; Desimone, > > > Nathaniel L <nathaniel.l.desim...@intel.com> > > > Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatformPkg: > > > Add BDS Hook Point Guids > > > > > > > > > Reviewed-by: Chasel Chiu <chasel.c...@intel.com> > > > > > > > -----Original Message----- > > > > From: Agyeman, Prince <prince.agye...@intel.com> > > > > Sent: Saturday, December 14, 2019 9:32 AM > > > > To: devel@edk2.groups.io > > > > Cc: Kubacki, Michael A <michael.a.kuba...@intel.com>; Chiu, Chasel > > > > <chasel.c...@intel.com>; Desimone, Nathaniel L > > > > <nathaniel.l.desim...@intel.com> > > > > Subject: [edk2-platforms] [PATCH 01/11] MinPlatformPkg: Add BDS Hook > > > > Point Guids > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336 > > > > > > > > Added BDS hook point guids as defined in the Minimum Platform > > > > specification. These GUIDs shall be used in the identification of > > > > three of the BDS hook point event groups. > > > > > > > > These event groups are Before Console After Trusted, Before Console > > > Before > > > > End Of Dxe and After Console Ready Before BootOption events. > > > > > > > > See > > > > https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-specification, > > > > under Appendix A.3 BDS Hook Points, for more details > > > > > > > > Cc: Michael Kubacki <michael.a.kuba...@intel.com> > > > > Cc: Chasel Chiu <chasel.c...@intel.com> > > > > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > > > > > > > > Signed-off-by: Prince Agyeman <prince.agye...@intel.com> > > > > --- > > > > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > > > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > > > index 7f74ac9380..5bec4eee3a 100644 > > > > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > > > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > > > @@ -46,6 +46,11 @@ > > > > gDefaultDataFileGuid = {0x1ae42876, 0x008f, 0x4161, > > > > {0xb2, 0xb7, 0x1c, 0x0d, 0x15, 0xc5, 0xef, 0x43}} > > > > gDefaultDataOptSizeFileGuid = {0x003e7b41, 0x98a2, 0x4be2, > > > > {0xb2, 0x7a, 0x6c, 0x30, 0xc7, 0x65, 0x52, 0x25}} > > > > > > > > + # BDS Hook point event Guids > > > > + gBdsEventBeforeConsoleAfterTrustedConsoleGuid = {0x51e49ff5, > > > > 0x28a9, 0x4159, { 0xac, 0x8a, 0xb8, 0xc4, 0x88, 0xa7, 0xfd, 0xee}} > > > > + gBdsEventBeforeConsoleBeforeEndOfDxeGuid = {0xfcf26e41, > > > > 0xbda6, 0x4633, { 0xb5, 0x73, 0xd4, 0xb8, 0x0e, 0x6d, 0xd0, 0x78}} > > > > + gBdsEventAfterConsoleReadyBeforeBootOptionGuid = {0x8eb3d5dc, > > > > 0xf4e7, > > > > + 0x4b57, { 0xa9, 0xe7, 0x27, 0x39, 0x10, 0xf2, 0x18, 0x9f}} > > > > + > > > > [LibraryClasses] > > > > > > > > PeiLib|Include/Library/PeiLib.h > > > > -- > > > > 2.19.1.windows.1 > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52298): https://edk2.groups.io/g/devel/message/52298 Mute This Topic: https://groups.io/mt/68590722/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
