On 4/24/20 6:35 AM, Wasim Khan via groups.io wrote:
-----Original Message-----
From: Ard Biesheuvel <[email protected]>
Sent: Friday, April 24, 2020 12:27 AM
To: Wasim Khan <[email protected]>
Cc: edk2-devel-groups-io <[email protected]>; Varun Sethi
<[email protected]>; Wu, Hao A <[email protected]>; Ni, Ray
<[email protected]>
Subject: Re: [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem
Limit Checks
On Thu, 23 Apr 2020 at 12:43, Wasim Khan <[email protected]> wrote:
With Address Translation Support, it is possible and also correct that
Mem and Pmem Limit cross the 4GB boundary.
Update the checks so that Mem/PMem Limit should not cross 4GB from the
Mem/PMem Base address.
Signed-off-by: Wasim Khan <[email protected]>
---
MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c
b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c
index d304fae..9cf7e98 100644
--- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c
+++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c
@@ -117,8 +117,8 @@ CreateRootBridge (
// Make sure Mem and MemAbove4G apertures are valid
//
if (RESOURCE_VALID (&Bridge->Mem)) {
- ASSERT (Bridge->Mem.Limit < SIZE_4GB);
- if (Bridge->Mem.Limit >= SIZE_4GB) {
+ ASSERT (Bridge->Mem.Limit < (Bridge->Mem.Base + SIZE_4GB));
+ if (Bridge->Mem.Limit >= (Bridge->Mem.Base + SIZE_4GB)) {
return NULL;
}
}
@@ -129,8 +129,8 @@ CreateRootBridge (
}
}
if (RESOURCE_VALID (&Bridge->PMem)) {
- ASSERT (Bridge->PMem.Limit < SIZE_4GB);
- if (Bridge->PMem.Limit >= SIZE_4GB) {
+ ASSERT (Bridge->PMem.Limit < (Bridge->PMem.Base + SIZE_4GB));
+ if (Bridge->PMem.Limit >= (Bridge->PMem.Base + SIZE_4GB)) {
return NULL;
}
}
--
2.7.4
This is not the right fix.
The translation offset should be taken into account for these checks
Thanks for the review Ard.
device address = host address + translation offset.
Mem and Pmem represents "device address" , so that are already taking
translation offset into account.
OK, apparently I am missing something.
For the MMIO32 window, the limit has to be < 4 GB, since the whole
region needs to be 32-bit addressable. Otherwise, how are you going to
allocate a 32-bit BAR from the part of the window that is > 4 GB ?
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#58019): https://edk2.groups.io/g/devel/message/58019
Mute This Topic: https://groups.io/mt/73215737/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
