On Wed, Jun 17, 2020 at 17:38:24 +0200, Ard Biesheuvel wrote: > The bounce buffering code in NonCoherentDmaLib copies data into the > bounce buffer using CopyMem(), but passes Map->HostAddress as the > source of the copy before it has been assigned its correct value.
Whoops. > Signed-off-by: Ard Biesheuvel <[email protected]> Reviewed-by: Leif Lindholm <[email protected]> > --- > EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.c > b/EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.c > index 115345765435..9c8ef5bfb533 100644 > --- a/EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.c > +++ b/EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.c > @@ -225,8 +225,7 @@ DmaMap ( > } > > if (Map->Operation == MapOperationBusMasterRead) { > - CopyMem (Map->BufferAddress, (VOID *)(UINTN)Map->HostAddress, > - *NumberOfBytes); > + CopyMem (Map->BufferAddress, (VOID *)(UINTN)HostAddress, > *NumberOfBytes); > } > mCpu->FlushDataCache (mCpu, (UINTN)Map->BufferAddress, AllocSize, > EfiCpuFlushTypeWriteBack); > -- > 2.27.0 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61423): https://edk2.groups.io/g/devel/message/61423 Mute This Topic: https://groups.io/mt/74939973/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
