This patch series refactors the error logging in the AcpiView functionality to a newly created logging facility.
The new error logging facility in AcpiViewLog.[ch] contains helper functions to log messages of various types and severities, enumerations of known error types as well as common abstractions for outputting the log. This allows for modularity when determining how the output should be delivered to the user as well as significantly reduced code footprint of the logging mechanism in the core AcpiView code. Tomas Pilar (8): ShellPkg/AcpiView: Extract configuration struct ShellPkg/AcpiView: Declutter error counters ShellPkg/AcpiView: Modify error message ShellPkg/AcpiView: Create a logging facility ShellPkg/AcpiView: Refactor PrintFieldName ShellPkg/AcpiView: Refactor dump helpers ShellPkg/AcpiView: Refactor AcpiView ShellPkg/AcpiView: Refactor table parsers .../UefiShellAcpiViewCommandLib/AcpiParser.c | 530 +++--------------- .../UefiShellAcpiViewCommandLib/AcpiParser.h | 173 +----- .../AcpiTableParser.c | 56 +- .../AcpiTableParser.h | 2 +- .../UefiShellAcpiViewCommandLib/AcpiView.c | 226 +++----- .../UefiShellAcpiViewCommandLib/AcpiView.h | 36 -- .../AcpiViewConfig.c | 180 +----- .../AcpiViewConfig.h | 138 +---- .../UefiShellAcpiViewCommandLib/AcpiViewLog.c | 266 +++++++++ .../UefiShellAcpiViewCommandLib/AcpiViewLog.h | 254 +++++++++ .../Arm/SbbrValidator.c | 65 +-- .../FieldFormatHelper.h | 164 ++++++ .../Parsers/Dbg2/Dbg2Parser.c | 119 ++-- .../Parsers/Fadt/FadtParser.c | 49 +- .../Parsers/Gtdt/GtdtParser.c | 84 +-- .../Parsers/Iort/IortParser.c | 208 +++---- .../Parsers/Madt/MadtParser.c | 99 +--- .../Parsers/Mcfg/McfgParser.c | 11 +- .../Parsers/Pptt/PpttParser.c | 166 ++---- .../Parsers/Rsdp/RsdpParser.c | 42 +- .../Parsers/Slit/SlitParser.c | 123 ++-- .../Parsers/Spcr/SpcrParser.c | 31 +- .../Parsers/Srat/SratParser.c | 189 ++----- .../Parsers/Xsdt/XsdtParser.c | 93 +-- .../UefiShellAcpiViewCommandLib.c | 22 +- .../UefiShellAcpiViewCommandLib.inf | 3 + 26 files changed, 1289 insertions(+), 2040 deletions(-) create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.c create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.h create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/FieldFormatHelper.h -- 2.24.1.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61807): https://edk2.groups.io/g/devel/message/61807 Mute This Topic: https://groups.io/mt/75193747/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-