Hi Liming, On 07/03/20 17:13, Gao, Liming wrote: > Include more people and collect the comments. > > ECC is the source file coding style checker. Here is its wiki page > https://github.com/tianocore/tianocore.github.io/wiki/ECC-tool. > If the changed code doesn't follow edk2 coding style, ECC will report the > error. > > This patch set enables ECC checker in open CI for each patch coming into edk2 > repo. That means new changes need to follow edk2 coding style. > Otherwise, new changes can't be merged. > > If you have some comments for ECC checker in open CI, please reply this mail.
(1) The ArmVirtPkg (v6 04/16) and OvmfPkg (v6 11/16) patches already carry my ACKs; from here: https://edk2.groups.io/g/devel/message/61154 https://edk2.groups.io/g/devel/message/61155 (2) The UefiCpuPkg patch (v6 15/16) *should* also carry my ACK, from here: https://edk2.groups.io/g/devel/message/61156 Shenglei picked up my ACK for v4 and v5: https://edk2.groups.io/g/devel/message/61283 https://edk2.groups.io/g/devel/message/61852 but then dropped it for v6: https://edk2.groups.io/g/devel/message/61894 Shenglei, can you please explain why you dropped my ACK from the UefiCpuPkg patch, in v6? (3) The initial discussion between Shenglei and myself are under the v2 posting: https://edk2.groups.io/g/devel/message/60665 https://edk2.groups.io/g/devel/message/60711 https://edk2.groups.io/g/devel/message/60961 I'm happy with this work because it lets package maintainers tailor ECC as they see appropriate. Thanks, Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62047): https://edk2.groups.io/g/devel/message/62047 Mute This Topic: https://groups.io/mt/75227224/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-