Ray, Hao, Eric, On 06/22/20 15:18, Kirkendall, Garrett wrote: > AMD processor does not support MSR_IA32_MISC_ENABLE register. Accessing > this register on AMD causes an unhandled exception in SmmEntry.nasm and > a subsequent failure to boot since this is too early in SMM path for the > exception handler to be loaded. > > 1. Prepare PcAtChipsetPkg/PcAtChipsetPkg.dsc to move > StandardSignatureIsAuthenticAMD into UefiCpuLib LibraryClass > BaseUefiCpuLib in UefiCpuPkg. > > 2. To distinguish between AMD and other processors, refactor > StandardSignatureIsAuthenticAMD into BaseUefiCpuLib. So there is only > one copy in the source. > > 3. Skip manipulation of MSR_IA32_MISC_ENABLE register if running > on an AMD processor. > > Tested on AMD X64 hardware. > OvmfIa32 and OvmfIa32X64 on Intel hardware. > > v1: Move StandardSignatureIsAuthenticAMD. Handle MSR_IA32_MISC_ENABLE > v2: Incorporate Laszlo's feedback > v3: Typo, not sent > v4: Patch in to add UefiCpuLib to PcAtChipsetPkg.dsc > v5: Patch in to add UefiCpuLib to SourceLevelDebugPkg.dsc > v6: Hopefully reformat patch when sending????
With <https://bugzilla.tianocore.org/show_bug.cgi?id=2825> fixed (commit 0060e0a694f3), this patch set should be merged now. I was about to do just that, but the review status of the series is still incomplete. Even though this patch series has been on the list for two weeks now. - Ray, can you please review patch#1 immediately? - Hao, can you please review patch#2 immediately? - Ray and Eric, can one of you please review patch #4 at once? Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62096): https://edk2.groups.io/g/devel/message/62096 Mute This Topic: https://groups.io/mt/75037833/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
