Laszlo: > -----Original Message----- > From: Laszlo Ersek <[email protected]> > Sent: Friday, July 3, 2020 11:49 PM > To: Gao, Liming <[email protected]>; [email protected]; > [email protected]; [email protected] > Cc: Rebecca Cran <[email protected]>; Andrew Fish <[email protected]>; Justen, > Jordan L <[email protected]>; Kinney, > Michael D <[email protected]> > Subject: Re: [edk2-devel] License Check - was OvmfPkg: Adding support for > bhyve as OvmfPkg/Bhyve > > On 07/03/20 03:40, Gao, Liming wrote: > > > Besides, there is another new checker of ECC to check coding style for each > > patch. Can you give your comment? > > https://edk2.groups.io/g/devel/message/61966 > > I've seen that feature. > > Importantly, it gives package maintainers package-level exception lists. > So if ECC rejects something, and the package maintainers disagree with > the rejection, they can create an exception inside the package, and > suppress the ECC report. > > We don't have the same option with PatchCheck. > > (For generated files anyway, that's what I'm suggesting in fact: if > PatchCheck sees the string "@file: generated" in a source file, it > should omit the license check altogether, for that file.)
License checker can be added as the same way to ECC checker. If so, the package maintainers can add the generated file as the exception. Thanks Liming > > Thanks! > Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62165): https://edk2.groups.io/g/devel/message/62165 Mute This Topic: https://groups.io/mt/75255538/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
