CI already runs PatchCheck. If we ported PatchCheck to a CI plugin, then the plugin could perform both the current PatchCheck features and the license check.
What this option evaluated? If we did provide PatchCheck as a CI plugin, developers I believe developers could run a stuart command likely for the NOOPT target to run a PatchCheck CI plugin locally. Thanks, Mike > -----Original Message----- > From: Zhang, Shenglei <shenglei.zh...@intel.com> > Sent: Monday, July 20, 2020 1:37 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Sean > Brogan <sean.bro...@microsoft.com>; Bret Barkelew > <bret.barke...@microsoft.com>; Dong, Eric > <eric.d...@intel.com>; Laszlo Ersek <ler...@redhat.com>; > Gao, Zhichao <zhichao....@intel.com>; Yao, Jiewen > <jiewen....@intel.com>; Chao Zhang > <chao.b.zh...@intel.com>; Justen, Jordan L > <jordan.l.jus...@intel.com>; Maciej Rabeda > <maciej.rab...@linux.intel.com>; Wu, Jiaxin > <jiaxin...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; > Gao, Liming <liming....@intel.com>; Wang, Jian J > <jian.j.w...@intel.com>; Wu, Hao A <hao.a...@intel.com>; > Andrew Fish <af...@apple.com>; Ni, Ray > <ray...@intel.com>; Lu, XiaoyuX <xiaoyux...@intel.com>; > Ard Biesheuvel <ard.biesheu...@arm.com>; Leif Lindholm > <l...@nuviainc.com> > Subject: [PATCH 00/15] Add a plugin LicenseCheck in open > ci > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2833 > LicenseCheck is now enabled in PatchCheck.py. But > there's > a patch "Revert 'BaseTools/PatchCheck.py: Add > LicenseCheck'" > to suggest revert the change.These patch series > introduce > a plugin LicenseCheck into open ci so that license > issues can > still be checked after the checker is disabled in > PatchCheck.py. > 1/15 is the plugin implementation. > 2/15 ~ 15/15 introduce sections "IgnoreFiles" to allow > developers > to skip license check for some files like generated > files. > > Only BSD-2-Clause-Patent and BSD-3-Clause-Patent can > pass this checker. > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Sean Brogan <sean.bro...@microsoft.com> > Cc: Bret Barkelew <bret.barke...@microsoft.com> > Cc: Eric Dong <eric.d...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Zhichao Gao <zhichao....@intel.com> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Chao Zhang <chao.b.zh...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Maciej Rabeda <maciej.rab...@linux.intel.com> > Cc: Jiaxin Wu <jiaxin...@intel.com> > Cc: Siyuan Fu <siyuan...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Hao A Wu <hao.a...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Andrew Fish <af...@apple.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Xiaoyu Lu <xiaoyux...@intel.com> > Cc: Ard Biesheuvel <ard.biesheu...@arm.com> > Cc: Leif Lindholm <l...@nuviainc.com> > Shenglei Zhang (15): > .pytool/Plugin: Add a plugin LicenseCheck > FatPkg/FatPkg.ci.yaml: Add configuration for > LicenseCheck > ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for > LicenseCheck > CryptoPkg/CryptoPkg.ci.yaml: Add configuration for > LicenseCheck > EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for > LicenseCheck > FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration > for LicenseCheck > MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration > for LicenseCheck > MdePkg/MdePkg.ci.yaml: Add configuration for > LicenseCheck > NetworkPkg/NetworkPkg.ci.yaml: Add configuration for > LicenseCheck > OvmfPkg/OvmfPkg.ci.yaml: Add configuration for > LicenseCheck > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add > configuration for > LicenseCheck > SecurityPkg/SecurityPkg.ci.yaml: Add configuration for > LicenseCheck > ShellPkg/ShellPkg.ci.yaml: Add configuration for > LicenseCheck > UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for > LicenseCheck > UnitTestFrameworkPkg: Add configuration for > LicenseCheck in yaml file > > .pytool/Plugin/LicenseCheck/LicenseCheck.py | 118 > ++++++++++++++++++ > .../LicenseCheck/LicenseCheck_plug_in.yaml | 11 ++ > .pytool/Plugin/LicenseCheck/Readme.md | 17 +++ > ArmVirtPkg/ArmVirtPkg.ci.yaml | 4 + > CryptoPkg/CryptoPkg.ci.yaml | 3 + > EmulatorPkg/EmulatorPkg.ci.yaml | 4 + > FatPkg/FatPkg.ci.yaml | 3 + > FmpDevicePkg/FmpDevicePkg.ci.yaml | 3 + > MdeModulePkg/MdeModulePkg.ci.yaml | 4 + > MdePkg/MdePkg.ci.yaml | 4 + > NetworkPkg/NetworkPkg.ci.yaml | 3 + > OvmfPkg/OvmfPkg.ci.yaml | 4 + > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 3 + > SecurityPkg/SecurityPkg.ci.yaml | 3 + > ShellPkg/ShellPkg.ci.yaml | 3 + > UefiCpuPkg/UefiCpuPkg.ci.yaml | 3 + > .../UnitTestFrameworkPkg.ci.yaml | 4 + > 17 files changed, 194 insertions(+) > create mode 100644 > .pytool/Plugin/LicenseCheck/LicenseCheck.py > create mode 100644 > .pytool/Plugin/LicenseCheck/LicenseCheck_plug_in.yaml > create mode 100644 > .pytool/Plugin/LicenseCheck/Readme.md > > -- > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63420): https://edk2.groups.io/g/devel/message/63420 Mute This Topic: https://groups.io/mt/75678207/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
