Thanks. All done reviewing. On the whole, it looks good, but there are some minor things left to clean up. So please send out a v2 based on the comments I made.
Best Regards, Leif On Wed, Aug 19, 2020 at 19:59:58 +0530, Tanmay Jagdale wrote: > This patch series adds ACPI tables support for the SbsaQemu platform. > We are using a pseudo static approach to create the ACPI tables. > > The ACPI tables namely DBG2, DSDT, MCFG, SPCR, GTDT are created in a > static way at compile time because they hold a fixed configuration > and there are no changes at runtime. > > The MADT, SSDT and PPTT tables are dependant on the number of CPUs and > hence they are created at runtime based on the number of CPUs the user > has requested. > > Tanmay Jagdale (7): > SbsaQemu: Initial support for static ACPI tables > SbsaQemu: AcpiTables: Add PCI support and MCFG Table > SbsaQemu: Add new ACPI driver and FDT parser to count CPUs > SbsaQemu: AcpiDxe: Create MADT table at runtime > SbsaQemu: AcpiDxe: Create SSDT table at runtime > SbsaQemu: AcpiDxe: Create PPTT table at runtime > SbsaQemu: AcpiTables: Add DBG2 Table > > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 12 +- > Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 9 + > Silicon/Qemu/SbsaQemu/Acpi.dsc.inc | 36 ++ > .../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 47 ++ > Silicon/Qemu/SbsaQemu/AcpiTables/Dbg2.aslc | 68 +++ > Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 449 ++++++++++++++++ > Silicon/Qemu/SbsaQemu/AcpiTables/Fadt.aslc | 80 +++ > Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc | 67 +++ > Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc | 43 ++ > Silicon/Qemu/SbsaQemu/AcpiTables/Spcr.aslc | 53 ++ > .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 490 ++++++++++++++++++ > .../SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 67 +++ > .../Include/IndustryStandard/SbsaQemuAcpi.h | 199 +++++++ > Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 8 +- > 14 files changed, 1624 insertions(+), 4 deletions(-) > create mode 100644 Silicon/Qemu/SbsaQemu/Acpi.dsc.inc > create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf > create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Dbg2.aslc > create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl > create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Fadt.aslc > create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc > create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc > create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Spcr.aslc > create mode 100644 > Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c > create mode 100644 > Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf > create mode 100644 > Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h > > -- > 2.28.0 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64501): https://edk2.groups.io/g/devel/message/64501 Mute This Topic: https://groups.io/mt/76287421/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
