Yes. This change is correct. Reviewed-by: Liming Gao <gaolim...@byosoft.com. cn>
> -----邮件原件----- > 发件人: bounce+27952+65182+4905953+8761...@groups.io > <bounce+27952+65182+4905953+8761...@groups.io> 代表 Ni, Ray > 发送时间: 2020年9月11日 10:19 > 收件人: Wenyi Xie <xiewen...@huawei.com>; devel@edk2.groups.io; Justen, > Jordan L <jordan.l.jus...@intel.com>; af...@apple.com; gaoliming > <gaolim...@byosoft.com.cn> > 抄送: ler...@redhat.com; songdongku...@huawei.com > 主题: Re: [edk2-devel] [PATCH EDK2 v1 1/1] EmulatorPkg:Change > DEC_VERSION to DEC_SPECIFICATION > > + Liming who is expert on the EDK II Build spec. > > > -----Original Message----- > > From: Wenyi Xie <xiewen...@huawei.com> > > Sent: Friday, September 11, 2020 9:49 AM > > To: devel@edk2.groups.io; Justen, Jordan L <jordan.l.jus...@intel.com>; > af...@apple.com; Ni, Ray <ray...@intel.com> > > Cc: ler...@redhat.com; songdongku...@huawei.com; > xiewen...@huawei.com > > Subject: [PATCH EDK2 v1 1/1] EmulatorPkg:Change DEC_VERSION to > DEC_SPECIFICATION > > > > edk2 DEC specification document only knows about DEC_SPECIFICATION, > > so using DEC_VERSION in [Defines] section in EmulatorPkg.dec is not > > correct. > > > > Cc: Jordan Justen <jordan.l.jus...@intel.com> > > Cc: Andrew Fish <af...@apple.com> > > Cc: Ray Ni <ray...@intel.com> > > Signed-off-by: Wenyi Xie <xiewen...@huawei.com> > > --- > > EmulatorPkg/EmulatorPkg.dec | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec > > index 90a8d2a8681a..064f963c72c6 100644 > > --- a/EmulatorPkg/EmulatorPkg.dec > > +++ b/EmulatorPkg/EmulatorPkg.dec > > @@ -11,7 +11,7 @@ > > ## > > > > [Defines] > > - DEC_VERSION = 0x00010005 > > + DEC_SPECIFICATION = 0x00010005 > > PACKAGE_NAME = EmulatorPkg > > PACKAGE_GUID = > 36E48BD7-7D92-5A47-A2CD-513F072E3300 > > PACKAGE_VERSION = 0.1 > > -- > > 2.20.1.windows.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65210): https://edk2.groups.io/g/devel/message/65210 Mute This Topic: https://groups.io/mt/76834779/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
