Reviewed-by: Yuwei Chen<yuwei.c...@intel.com> > -----Original Message----- > From: Feng, Bob C <bob.c.f...@intel.com> > Sent: Wednesday, September 23, 2020 8:37 PM > To: devel@edk2.groups.io > Cc: Liming Gao <gaolim...@byosoft.com.cn>; Chen, Christine > <yuwei.c...@intel.com> > Subject: [Patch] BaseTools: Remove CanSkip calling for incremental build > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2978 > > If a module add a new PCD, the pcd token number will be reassigned. The > new Pcd token number should be updated to all module's autogen files. > CanSkip can only detect a single module's change but not others. CanSkip > block the pcd token number update in incremental build, so this patch is > going to remove this call. > > Signed-off-by: Bob Feng <bob.c.f...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Yuwei Chen <yuwei.c...@intel.com> > --- > BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > index dc8b1fe3d1..eebf6e87f5 100755 > --- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > +++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > @@ -1820,13 +1820,10 @@ class ModuleAutoGen(AutoGen): > > if not self.IsLibrary and CreateLibraryCodeFile: > for LibraryAutoGen in self.LibraryAutoGenList: > LibraryAutoGen.CreateCodeFile() > > - # CanSkip uses timestamps to determine build skipping > - if self.CanSkip(): > - return > self.LibraryAutoGenList > AutoGenList = [] > IgoredAutoGenList = [] > > for File in self.AutoGenFileList: > -- > 2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65591): https://edk2.groups.io/g/devel/message/65591 Mute This Topic: https://groups.io/mt/77033757/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
