On Thu, 11 Feb 2021 at 02:04, <mikub...@linux.microsoft.com> wrote: > > From: Michael Kubacki <michael.kuba...@microsoft.com> > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3204 > > Fixes the following compiler warning in VS2019 by changing defining > the MmramRangeCount variable to be UINTN and type casting prior > to value assignment. > > \edk2\StandaloneMmPkg\Core\StandaloneMmCore.c(570): error C2220: > the following warning is treated as an error > \edk2\StandaloneMmPkg\Core\StandaloneMmCore.c(570): warning C4244: > '=': conversion from 'UINT64' to 'UINT32', possible loss of data > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > Cc: Sami Mujawar <sami.muja...@arm.com> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Supreeth Venkatesh <supreeth.venkat...@arm.com> > Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com> > Reviewed-by: Sami Mujawar <sami.muja...@arm.com>
Merged, thanks. > --- > > Notes: > V2 changes: Remove whitespace after typecast. Update Ard's email address > > StandaloneMmPkg/Core/StandaloneMmCore.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.c > b/StandaloneMmPkg/Core/StandaloneMmCore.c > index 8388ec289ca8..fbb0ec75e557 100644 > --- a/StandaloneMmPkg/Core/StandaloneMmCore.c > +++ b/StandaloneMmPkg/Core/StandaloneMmCore.c > @@ -511,7 +511,7 @@ StandaloneMmMain ( > EFI_HOB_GUID_TYPE *MmramRangesHob; > EFI_MMRAM_HOB_DESCRIPTOR_BLOCK *MmramRangesHobData; > EFI_MMRAM_DESCRIPTOR *MmramRanges; > - UINT32 MmramRangeCount; > + UINTN MmramRangeCount; > EFI_HOB_FIRMWARE_VOLUME *BfvHob; > > ProcessLibraryConstructorList (HobStart, &gMmCoreMmst); > @@ -546,7 +546,7 @@ StandaloneMmMain ( > MmramRangesHobData = GET_GUID_HOB_DATA (MmramRangesHob); > ASSERT (MmramRangesHobData != NULL); > MmramRanges = MmramRangesHobData->Descriptor; > - MmramRangeCount = MmramRangesHobData->NumberOfMmReservedRegions; > + MmramRangeCount = (UINTN)MmramRangesHobData->NumberOfMmReservedRegions; > ASSERT (MmramRanges); > ASSERT (MmramRangeCount); > > @@ -554,7 +554,7 @@ StandaloneMmMain ( > // Copy the MMRAM ranges into MM_CORE_PRIVATE_DATA table just in case any > // code relies on them being present there > // > - gMmCorePrivate->MmramRangeCount = MmramRangeCount; > + gMmCorePrivate->MmramRangeCount = (UINT64)MmramRangeCount; > gMmCorePrivate->MmramRanges = > (EFI_PHYSICAL_ADDRESS)(UINTN)AllocatePool (MmramRangeCount * sizeof > (EFI_MMRAM_DESCRIPTOR)); > ASSERT (gMmCorePrivate->MmramRanges != 0); > @@ -567,7 +567,7 @@ StandaloneMmMain ( > DataInHob = GET_GUID_HOB_DATA (GuidHob); > gMmCorePrivate = (MM_CORE_PRIVATE_DATA *)(UINTN)DataInHob->Address; > MmramRanges = (EFI_MMRAM_DESCRIPTOR > *)(UINTN)gMmCorePrivate->MmramRanges; > - MmramRangeCount = gMmCorePrivate->MmramRangeCount; > + MmramRangeCount = (UINTN)gMmCorePrivate->MmramRangeCount; > } > > // > -- > 2.28.0.windows.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71602): https://edk2.groups.io/g/devel/message/71602 Mute This Topic: https://groups.io/mt/80547951/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
