This patch breaks booting on master. In CpuDxe.efi / InitGlobalDescriptorTable as the GDT pointer is casted to 32bits.
Regards, Patrick On Fri, Feb 19, 2021 at 3:12 AM Ma, Maurice <maurice...@intel.com> wrote: > > Reviewed-by: Maurice Ma <maurice...@intel.com> > > Regards > Maurice > > > -----Original Message----- > > From: Dong, Guo <guo.d...@intel.com> > > Sent: Sunday, February 14, 2021 21:13 > > To: devel@edk2.groups.io > > Cc: Ma, Maurice <maurice...@intel.com>; You, Benjamin > > <benjamin....@intel.com> > > Subject: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove > > 4GB memory WA > > > > Previous it would hang in CpuDxe if DXE drivers are dispatched above 4GB. > > Now remove the work around since the fixed in CpuDxe are merged. > > > > Signed-off-by: Guo Dong <guo.d...@intel.com> > > --- > > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c > > b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c > > index 805f5448d9..c403b0a80a 100644 > > --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c > > +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c > > @@ -40,11 +40,6 @@ MemInfoCallback ( > > EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE | > > EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE; > > > > - if (Base >= BASE_4GB ) { > > - // Remove tested attribute to avoid DXE core to dispatch driver to > > memory above 4GB > > - Attribue &= ~EFI_RESOURCE_ATTRIBUTE_TESTED; > > - } > > - > > BuildResourceDescriptorHob (Type, Attribue, > > (EFI_PHYSICAL_ADDRESS)Base, Size); > > DEBUG ((DEBUG_INFO , "buildhob: base = 0x%lx, size = 0x%lx, type = > > 0x%x\n", Base, Size, Type)); > > > > -- > > 2.16.2.windows.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71957): https://edk2.groups.io/g/devel/message/71957 Mute This Topic: https://groups.io/mt/80647875/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-