On Tue, Feb 23, 2021 at 13:42:49 +0100, Ard Biesheuvel wrote: > On Tue, 23 Feb 2021 at 12:07, Ming Huang <huangm...@linux.alibaba.com> wrote: > > > > The register address of GICR_IPRIORITYR is in SGI_base frame. Add > > IPRIORITY_ADDRESS macro for getting GICR_IPRIORITYR address. Otherwise > > GIC RAS error(Uncorrected software error) may report in ArmGicDxe. > > NOTE: missing sign-off > > Patch seems fine to me > > Tested-by: Ard Biesheuvel <a...@kernel.org> # QEMU/kvm guest on ThunderX2
Also looks good in QEMU. Reviewed-by: Leif Lindholm <l...@nuviainc.com> Ming, can you confirm that the contribution conforms to the developer certificate of origin by replyint with your Signed-off-by: ? > > > > > --- > > ArmPkg/Drivers/ArmGic/ArmGicLib.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c > > b/ArmPkg/Drivers/ArmGic/ArmGicLib.c > > index 8ef32b33a1..b4d3965acb 100644 > > --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c > > +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c > > @@ -30,6 +30,9 @@ > > #define ICENABLER_ADDRESS(base,offset) ((base) + \ > > ARM_GICR_CTLR_FRAME_SIZE + ARM_GICR_ICENABLER + (4 * offset)) > > > > +#define IPRIORITY_ADDRESS(base,offset) ((base) + \ > > + ARM_GICR_CTLR_FRAME_SIZE + ARM_GIC_ICDIPR + (4 * offset)) > > + > > /** > > * > > * Return whether the Source interrupt index refers to a shared interrupt > > (SPI) > > @@ -236,7 +239,7 @@ ArmGicSetInterruptPriority ( > > } > > > > MmioAndThenOr32 ( > > - GicCpuRedistributorBase + ARM_GIC_ICDIPR + (4 * RegOffset), > > + IPRIORITY_ADDRESS (GicCpuRedistributorBase, RegOffset), > > ~(0xff << RegShift), > > Priority << RegShift > > ); > > -- > > 2.17.1 > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72051): https://edk2.groups.io/g/devel/message/72051 Mute This Topic: https://groups.io/mt/80848339/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
