Hi,

On 3/24/21 4:45 AM, Sunny Wang wrote:
Merge changes in edk2-platforms-raspberrypi-pl011-bth-noflow.diff in
https://github.com/worproject/RPi-Bluetooth-Testing/ for enabling
Bluetooth and serial port (Mini UART) in Windows OS.

Testing Done:
   - Successfully booted Windows 10 (20279.1) on SD (made by WOR) with
     the RPi-Windows-Drivers release ver 0.5 downloaded from
     https://github.com/worproject/RPi-Windows-Drivers/releases
     and checked that both Bluetooth and serial port (Mini UART) can
     work fine.

Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com>
Cc: Sami Mujawar <sami.muja...@arm.com>
Cc: Jeremy Linton <jeremy.lin...@arm.com>
Cc: Pete Batard <p...@akeo.ie>
Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
Signed-off-by: Sunny Wang <sunny.w...@arm.com>
---
  Platform/RaspberryPi/AcpiTables/Uart.asl | 8 +++++++-
  1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Platform/RaspberryPi/AcpiTables/Uart.asl 
b/Platform/RaspberryPi/AcpiTables/Uart.asl
index 8ce297078d..e3165911a6 100644
--- a/Platform/RaspberryPi/AcpiTables/Uart.asl
+++ b/Platform/RaspberryPi/AcpiTables/Uart.asl
@@ -30,6 +30,12 @@ Device (URT0)
    {
      MEMORY32FIXED (ReadWrite, 0, BCM2836_PL011_UART_LENGTH, RMEM)
      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 
BCM2836_PL011_UART_INTERRUPT }
+
+    PinFunction (Exclusive, PullDown, BCM_ALT3, "\\_SB.GDV0.GPI0", 0, 
ResourceConsumer, , ) { 32, 33 }
+
+    // fake the CTS signal as we don't support HW flow control yet
+    // BCM_ALT2 is set as output (low) by default
+    PinFunction (Exclusive, PullNone, BCM_ALT2, "\\_SB.GDV0.GPI0", 0, 
ResourceConsumer, , ) { 31 }
    })
    Method (_CRS, 0x0, Serialized)
    {
@@ -142,7 +148,7 @@ Device(BTH0)
        //
        // RPIQ connection for BT_ON/OFF
        //
-      GpioIO (Shared, PullUp, 0, 0, IoRestrictionNone, "\\_SB.GDV0.RPIQ", 0, 
ResourceConsumer, , ) { 128 }
+      //GpioIO (Shared, PullUp, 0, 0, IoRestrictionNone, "\\_SB.GDV0.RPIQ", 0, 
ResourceConsumer, , ) { 128 }
      })
      Return (RBUF)
    }


Having come to this a bit late, its always made me a bit uncomfortable that some of these tables are doing blanket power/etc configuration in _CRS, is there are reason for continuing this rather than doing this via power states?




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73238): https://edk2.groups.io/g/devel/message/73238
Mute This Topic: https://groups.io/mt/81572764/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to