Dandan,

I am not sure if one dsc.inc file should include another dsc.inc file.

If a package/platform DSC file has a dependency on other packages to build,
then that DSC file can include the dsc.inc files from those dependent packages.
This limits the dsc.inc include depth is 1.  Nesting includes of dsc.inc files 
increases complexity.

Thanks,

Mike

> -----Original Message-----
> From: Bi, Dandan <dandan...@intel.com>
> Sent: Friday, March 26, 2021 12:24 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Sean Brogan 
> <sean.bro...@microsoft.com>; Bret Barkelew
> <bret.barke...@microsoft.com>
> Subject: [patch V3 27/29] UnitTestFrameworkPkg: Consume MdeLibs.dsc.inc for 
> RegisterFilterLib
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
> 
> MdeLibs.dsc.inc was added for some basic/default library
> instances provided by MdePkg and RegisterFilterLibNull Library
> was also added into it as the first version of MdeLibs.dsc.inc.
> 
> So update platform dsc to consume MdeLibs.dsc.inc for
> RegisterFilterLibNull which will be consumed by IoLib and BaseLib.
> 
> Cc: Michael D Kinney <michael.d.kin...@intel.com>
> Cc: Sean Brogan <sean.bro...@microsoft.com>
> Cc: Bret Barkelew <bret.barke...@microsoft.com>
> Signed-off-by: Dandan Bi <dandan...@intel.com>
> ---
>  UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc
> b/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc
> index 8adf690098..68ad37e989 100644
> --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc
> +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc
> @@ -1,13 +1,15 @@
>  ## @file
>  # UnitTestFrameworkPkg DSC include file for target based test DSC
>  #
> -# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR>
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
>  ##
> 
> +!include MdePkg/MdeLibs.dsc.inc
> +
>  [LibraryClasses]
>    #
>    # Entry point
>    #
>    PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
> --
> 2.18.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73396): https://edk2.groups.io/g/devel/message/73396
Mute This Topic: https://groups.io/mt/81622796/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to