I see. That makes sense. Thanks for the clarification. Regards, Sai
-----Original Message----- From: Kinney, Michael D <michael.d.kin...@intel.com> Sent: Friday, March 26, 2021 11:07 AM To: devel@edk2.groups.io; Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: RE: [edk2-devel] [edk2-platforms] [patch V3 29/35] Silicon/TigerlakeSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib Hi Sai, The latest patch series adds [LibraryClasses] statement to the MdeLibs.dsc.inc on purpose so MdeLibs.dsc.inc can be extended to support multiple library classes sections for different CPU archs and different modules types as needed in the future. Putting the !include outside the [LibraryClasses.common] section for Tigerlake is the correct way to consume MdeLibs.dsc.inc. Thanks, Mike > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > Chaganty, Rangasai V > Sent: Friday, March 26, 2021 9:22 AM > To: Bi, Dandan <dandan...@intel.com>; devel@edk2.groups.io > Cc: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Luo, Heng > <heng....@intel.com> > Subject: Re: [edk2-devel] [edk2-platforms] [patch V3 29/35] > Silicon/TigerlakeSiliconPkg: Consume MdeLibs.dsc.inc for > RegisterFilterLib > > Since this .dsc include is building some basic library instances from > MdePkg, please move the include under [LibraryClasses.common] section, > preferably under the #Basic category. > > Thanks, > Sai > > -----Original Message----- > From: Bi, Dandan <dandan...@intel.com> > Sent: Friday, March 26, 2021 1:39 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Desimone, > Nathaniel L <nathaniel.l.desim...@intel.com>; Luo, Heng > <heng....@intel.com> > Subject: [edk2-platforms] [patch V3 29/35] > Silicon/TigerlakeSiliconPkg: Consume MdeLibs.dsc.inc for > RegisterFilterLib > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 > > MdeLibs.dsc.inc was added for some basic/default library instances > provided by MdePkg and RegisterFilterLibNull Library was also added into it > as the first version of MdeLibs.dsc.inc. > > So update platform dsc to consume MdeLibs.dsc.inc for RegisterFilterLibNull > which will be consumed by IoLib and BaseLib. > > Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Heng Luo <heng....@intel.com> > Signed-off-by: Dandan Bi <dandan...@intel.com> > --- > V3: > Update plaftom dsc to consume the MdeLibs.dsc.inc outside the common > [LibraryClasses] section since we can specify different [LibraryClasses] > section for libary instances in MdeLibs.dsc.inc. > --- > Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc > b/Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc > index 73a2594887..36df41f09f 100644 > --- a/Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc > +++ b/Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc > @@ -90,10 +90,12 @@ [Defines] > # > # Definition for Build Flag > # > !include $(PLATFORM_SI_PACKAGE)/SiPkgBuildOption.dsc > > + !include MdePkg/MdeLibs.dsc.inc > + > [LibraryClasses.common] > # > # Entry point > # > > PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.i > nf > -- > 2.18.0.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73403): https://edk2.groups.io/g/devel/message/73403 Mute This Topic: https://groups.io/mt/81623461/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
