> -----Original Message-----
> From: gaoliming <[email protected]>
> Sent: Monday, April 12, 2021 6:28 PM
> To: [email protected]; Kinney, Michael D <[email protected]>
> Cc: Yao, Jiewen <[email protected]>; Wang, Jian J <[email protected]>; 
> Lu, XiaoyuX <[email protected]>; Jiang,
> Guomin <[email protected]>; Liu, Zhiguang <[email protected]>; 
> Feng, Bob C <[email protected]>; Chen,
> Christine <[email protected]>; 'Andrew Fish' <[email protected]>; 'Abner 
> Chang' <[email protected]>
> Subject: 回复: [edk2-devel] [Patch 0/3] Remove fixed CPU architecture list 
> assumptions
> 
> Mike:
>   Is this update for new ARCH support? With this patch set, new ARCH support
> doesn't need to modify BaseTools. Right?

Correct

> 
>   For this patch set 3/3 BaseTools/Source, I may suggest to split it to two
> patches, one is for C tools, another is for Python tools.

I agree.  I will send V2.

> 
>   For other patch, they are good to me. Reviewed-by: Liming Gao
> <[email protected]>
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: [email protected] <[email protected]> 代表 Michael D
> > Kinney
> > 发送时间: 2021年4月8日 14:33
> > 收件人: [email protected]
> > 抄送: Jiewen Yao <[email protected]>; Jian J Wang
> > <[email protected]>; Xiaoyu Lu <[email protected]>; Guomin Jiang
> > <[email protected]>; Liming Gao <[email protected]>;
> > Zhiguang Liu <[email protected]>; Bob Feng <[email protected]>;
> > Yuwei Chen <[email protected]>; Andrew Fish <[email protected]>;
> > Abner Chang <[email protected]>
> > 主题: [edk2-devel] [Patch 0/3] Remove fixed CPU architecture list
> > assumptions
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3308
> >
> > The EDK II Build Specifications do not restrict the set of
> > CPU architectures that can be supported.  Remove places in
> > the EDK II that assume a fixed set of CPU architectures.
> >
> > Remove build breaks in the following tools and DEFINES when a check
> against
> > a fixed set of CPU architectures is made.
> >
> > * Build
> > * GenFds
> > * TargetTool
> > * GenFw
> > * SIXTY_FOUR_BIT and THIRTY_TWO_BIT
> > * EFI_IMAGE_MACHINE_TYPE_SUPPORTED
> > * EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED
> > * EFI_REMOVABLE_MEDIA_FILE_NAME
> >
> > Cc: Jiewen Yao <[email protected]>
> > Cc: Jian J Wang <[email protected]>
> > Cc: Xiaoyu Lu <[email protected]>Cc
> > Cc: Guomin Jiang <[email protected]>
> > Cc: Liming Gao <[email protected]>
> > Cc: Zhiguang Liu <[email protected]>
> > Cc: Bob Feng <[email protected]>
> > Cc: Yuwei Chen <[email protected]>
> > Cc: Andrew Fish <[email protected]>
> > Cc: Abner Chang <[email protected]>
> > Signed-off-by: Michael D Kinney <[email protected]>
> >
> > Michael D Kinney (3):
> >   MdePkg/Include: Allow CPU specific defines to be predefined
> >   CryptoPkg/Library/Include: Allow CPU specific defines to be predefined
> >   BaseTools/Source: Remove CPU architecture assumptions
> >
> >  BaseTools/Source/C/GenFw/Elf32Convert.c          | 5 ++---
> >  BaseTools/Source/C/GenFw/Elf64Convert.c          | 5 ++---
> >  BaseTools/Source/Python/GenFds/FdfParser.py      | 4 +---
> >  BaseTools/Source/Python/TargetTool/TargetTool.py | 4 ++--
> >  BaseTools/Source/Python/build/buildoptions.py    | 4 ++--
> >  CryptoPkg/Library/Include/CrtLibSupport.h        | 2 ++
> >  MdePkg/Include/Uefi/UefiBaseType.h               | 4 +++-
> >  MdePkg/Include/Uefi/UefiSpec.h                   | 4 +++-
> >  8 files changed, 17 insertions(+), 15 deletions(-)
> >
> > --
> > 2.31.1.windows.1
> >
> >
> >
> > 
> >
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74008): https://edk2.groups.io/g/devel/message/74008
Mute This Topic: https://groups.io/mt/82056247/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to