> -----Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, April 13, 2021 9:08 PM > To: Chang, Abner (HPS SW/FW Technologist) <abner.ch...@hpe.com>; > devel@edk2.groups.io > Cc: Jiaxin Wu <jiaxin...@intel.com>; Ting Ye <ting...@intel.com>; Siyuan Fu > <siyuan...@intel.com>; Fan Wang <fan.w...@intel.com>; Jiewen Yao > <jiewen....@intel.com>; Wang, Nickle (HPS SW) <nickle.w...@hpe.com>; > Andrew Fish <af...@apple.com>; Leif Lindholm <l...@nuviainc.com>; > Michael D Kinney <michael.d.kin...@intel.com> > Subject: Re: [PATCH] RedfishPkg: Add EDK2 Redfish Foundation diagrams > > On 04/13/21 12:44, Chang, Abner (HPS SW/FW Technologist) wrote: > > > > > >> -----Original Message----- > >> From: Laszlo Ersek [mailto:ler...@redhat.com] > >> Sent: Tuesday, April 13, 2021 6:19 PM > >> To: Chang, Abner (HPS SW/FW Technologist) <abner.ch...@hpe.com>; > >> devel@edk2.groups.io > >> Cc: Jiaxin Wu <jiaxin...@intel.com>; Ting Ye <ting...@intel.com>; Siyuan > Fu > >> <siyuan...@intel.com>; Fan Wang <fan.w...@intel.com>; Jiewen Yao > >> <jiewen....@intel.com>; Wang, Nickle (HPS SW) > <nickle.w...@hpe.com>; > >> Andrew Fish <af...@apple.com>; Leif Lindholm <l...@nuviainc.com>; > >> Michael D Kinney <michael.d.kin...@intel.com> > >> Subject: Re: [PATCH] RedfishPkg: Add EDK2 Redfish Foundation diagrams > >> > >> On 04/13/21 02:10, Abner Chang wrote: > >>> The Readme.md to delineate the EFK2 Redfish foundation driver > >>> stack. > >>> > >>> Signed-off-by: Abner Chang <abner.ch...@hpe.com> > >>> > >>> Cc: Jiaxin Wu <jiaxin...@intel.com> > >>> Cc: Ting Ye <ting...@intel.com> > >>> Cc: Siyuan Fu <siyuan...@intel.com> > >>> Cc: Fan Wang <fan.w...@intel.com> > >>> Cc: Jiewen Yao <jiewen....@intel.com> > >>> Cc: Nickle Wang <nickle.w...@hpe.com> > >>> Cc: Andrew Fish <af...@apple.com> > >>> Cc: Laszlo Ersek <ler...@redhat.com> > >>> Cc: Leif Lindholm <l...@nuviainc.com> > >>> Cc: Michael D Kinney <michael.d.kin...@intel.com> > >>> --- > >>> RedfishPkg/Readme.md | 117 ++++++++++++++++++ > >>> .../Documents/Media/RedfishDriverStack.png | Bin 0 -> 157408 bytes > >>> 2 files changed, 117 insertions(+) > >>> create mode 100644 RedfishPkg/Readme.md > >>> create mode 100644 > >> RedfishPkg/Documents/Media/RedfishDriverStack.png > >> > >> Why am I expected to review this? > > I thought you are the steward and may give comments on the readme > markdown with image of the diagrams under RedfishPkg. But you did have > comments on the RFC so that's another reason to invite you for the review, > not mandatory though :D > > Same message to Andrew, Leif and Mike. > > Right... but my earlier comments suggested SVG, and Mike suggested > another plaintext-based graphics format (sorry the name eludes me at the > moment). So why is there a PNG in this patch? Oops, my fault. I forget this after the weekend. Thanks to the review process and having you as the reviewer. :) Sure, I will have v2 patch set for the SVG format. PlantUML graphics format will be used for the porting guide on Wiki.
Abner > > Thanks > Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74048): https://edk2.groups.io/g/devel/message/74048 Mute This Topic: https://groups.io/mt/82054543/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
