Reviewed-by: Bret Barkelew <bret.barke...@microsoft.com> - Bret
From: Getnat Ejigu<mailto:getnatej...@gmail.com> Sent: Friday, April 30, 2021 2:07 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: Kinney, Michael D<mailto:michael.d.kin...@intel.com>; Sean Brogan<mailto:sean.bro...@microsoft.com>; Bret Barkelew<mailto:bret.barke...@microsoft.com> Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI to ReportPrint() function that use VA_ARGS. Signed-off-by: Getnat Ejigu <getnatej...@gmail.com> Cc: Michael D Kinney <michael.d.kin...@intel.com> Cc: Sean Brogan <sean.bro...@microsoft.com> Cc: Bret Barkelew <bret.barke...@microsoft.com> --- UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c | 1 + UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c | 1 + UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c | 1 + 3 files changed, 3 insertions(+) diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c index 66c9db457d80..7f7443a23391 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c @@ -11,6 +11,7 @@ #include <Library/DebugLib.h> VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c index cfb0c5972bd1..db5402d6a210 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c @@ -12,6 +12,7 @@ #include <Library/DebugLib.h> VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c index 1402d0ef83e2..1d62c6a37117 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c @@ -11,6 +11,7 @@ #include <Library/DebugLib.h> VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... -- 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74682): https://edk2.groups.io/g/devel/message/74682 Mute This Topic: https://groups.io/mt/82492217/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
