On 05/10/21 21:33, Lendacky, Thomas wrote: > On 5/10/21 9:24 AM, Lendacky, Thomas via groups.io wrote: >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3385 >> >> A VS2012 build fails with a cast conversion warning when the SEV-ES work >> area PCD is cast as a pointer to the SEV_ES_AP_JMP_FAR type. >> >> When casting from a PCD value to a pointer, the cast should first be done >> to a UINTN and then to the pointer. Update the code to perform a cast to >> a UINTN before casting to a pointer to the SEV_ES_AP_JMP_FAR type. >> > > I should have included a Fixes: 7b7508ad784d16a5208c8d12dff43aef6df0835b tag. >
Thanks for the note, I'm picking that up. Laszlo > Tom > >> Cc: Eric Dong <eric.d...@intel.com> >> Cc: Ray Ni <ray...@intel.com> >> Cc: Laszlo Ersek <ler...@redhat.com> >> Cc: Rahul Kumar <rahul1.ku...@intel.com> >> Signed-off-by: Tom Lendacky <thomas.lenda...@amd.com> >> --- >> UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c >> b/UefiCpuPkg/Library/MpInitLib/MpLib.c >> index 3d945972a025..dc2a54aa31e8 100644 >> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c >> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c >> @@ -1265,7 +1265,7 @@ SetSevEsJumpTable ( >> UINT32 Offset, InsnByte; >> UINT8 LoNib, HiNib; >> >> - JmpFar = (SEV_ES_AP_JMP_FAR *) FixedPcdGet32 (PcdSevEsWorkAreaBase); >> + JmpFar = (SEV_ES_AP_JMP_FAR *) (UINTN) FixedPcdGet32 >> (PcdSevEsWorkAreaBase); >> ASSERT (JmpFar != NULL); >> >> // >> > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75023): https://edk2.groups.io/g/devel/message/75023 Mute This Topic: https://groups.io/mt/82721039/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-