Just like to give my RB: Reviewed-by: Star Zeng <star.z...@intel.com> Please also get the RB from maintainer. 😊
Thanks, Star -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of PierreGondois Sent: 2021年6月2日 6:05 To: devel@edk2.groups.io; Bi, Dandan <dandan...@intel.com>; gaolim...@byosoft.com.cn; Kinney, Michael D <michael.d.kin...@intel.com>; sami.muja...@arm.com; alexei.fedo...@arm.com Subject: [edk2-devel] [PATCH v1 0/2] Define AML_NAME_SEG_SIZE From: Pierre Gondois <pierre.gond...@arm.com> There is currently multiple AML_NAME_SEG_SIZE define in the edk2 repository. One in the MdeModulePkg and one in the DynamicTablesPkg package. Since the value can be inferred from the ACPI specification, it could be moved to MdePkg/Include/IndustryStandard/ and avoid re-definitions The two patches should be merged at once to avoid having multiple definitions of AML_NAME_SEG_SIZE. The changes can be seen at: https://github.com/PierreARM/edk2/tree/1750_Add_AML_NAMESEG_SIZE_v1 The results of the CI can be seen at: https://github.com/tianocore/edk2/pull/1681 Pierre Gondois (2): MdePkg/MdeModulePkg: Move AML_NAME_SEG_SIZE definition DynamicTablesPkg: Use AML_NAME_SEG_SIZE define .../Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c | 4 ++-- .../AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c | 4 ++-- DynamicTablesPkg/Library/Common/AmlLib/AmlDefines.h | 9 +-------- MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiSdt.h | 1 - MdePkg/Include/IndustryStandard/AcpiAml.h | 7 ++++++- 5 files changed, 11 insertions(+), 14 deletions(-) -- 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75942): https://edk2.groups.io/g/devel/message/75942 Mute This Topic: https://groups.io/mt/83245166/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
